From owner-freebsd-gecko@FreeBSD.ORG Fri Nov 5 14:12:24 2010 Return-Path: Delivered-To: freebsd-gecko@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC166106564A for ; Fri, 5 Nov 2010 14:12:23 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id BC5EB8FC14 for ; Fri, 5 Nov 2010 14:12:23 +0000 (UTC) Received: by pzk7 with SMTP id 7so494529pzk.13 for ; Fri, 05 Nov 2010 07:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=dXca1ebtdkI6CqIQEuUHUn0zwne8l5mEgyQq3CFvxmo=; b=JT2SFeJ+cTRoJF1m+jH1+G0/YKD+cMVoiqP99V4mVOmjZTcY4pZBgKwzUH6b2Au1j6 CALQtmBw7KniV2bhibpY7Y7vaXymWFtirzV+11w3OPeT1E/l09ld2mLXUcnhdSn+5jJS xFquYha7CBc6sxn+HO/EDciLxkWZua1T20qYo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; b=AfStiPu/XNSKabfCU+BIww7rbIOl3zdTrzgDsr0KLhMRQRhRkPVpWmbsYISfxvn+fV ydt13HwzQimJaWFv038DrdeJW0kVDvTKc9oj7SrOuScYr75YWuvFy19EQdotOobcqsUK 7vkRhpCG+E1++1a9UF/3UlHWuD78BicqAq44A= Received: by 10.142.128.11 with SMTP id a11mr121576wfd.295.1288966343103; Fri, 05 Nov 2010 07:12:23 -0700 (PDT) Received: from localhost (cpe-66-8-211-107.hawaii.res.rr.com [66.8.211.107]) by mx.google.com with ESMTPS id w22sm1823860wfd.7.2010.11.05.07.12.17 (version=SSLv3 cipher=RC4-MD5); Fri, 05 Nov 2010 07:12:21 -0700 (PDT) From: Anonymous To: freebsd-gecko@freebsd.org References: <201011022113.oA2LD12f028438@trillian.chruetertee.ch> <86mxposuzj.fsf@gmail.com> Date: Fri, 05 Nov 2010 17:11:59 +0300 In-Reply-To: <86mxposuzj.fsf@gmail.com> (Anonymous's message of "Thu, 04 Nov 2010 23:18:40 +0300") Message-ID: <86zktn272o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [SVN-Commit] r430 - in branches/experimental/www/firefox-devel: . files X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2010 14:12:24 -0000 Anonymous writes: > svn-freebsd-gecko@chruetertee.ch writes: > >> Author: beat >> Date: Tue Nov 2 21:13:01 2010 >> New Revision: 430 >> >> Log: > [...] >> - Add patches from Firefox 3.6 to fix build with recent gcc versions. It >> still does not build with gcc44+. > > Do you have tinderbox log? Try below diff, it's against snapshot, though. [...] > + # if defined(__FreeBSD__) > ++# include > + # include > + # endif Oops, I guess it should be defined explicitly otherwise js-shell fails on linking. gmake[2]: Entering directory `/usr/ports/www/firefox-devel/work/mozilla-central/js/src/shell' g++45 -o js [...] ../libjs_static.a /usr/local/bin/ld: error: hidden symbol 'pthread_attr_get_np' is not defined locally --- before (readelf -a) +++ after (readelf -a) @@ -83,7 +83,7 @@ Relocation section '.rela.text' at offse Offset Info Type Sym. Value Sym. Name + Addend 000000000007 001100000004 R_X86_64_PLT32 0000000000000000 pthread_self - 4 000000000017 001200000004 R_X86_64_PLT32 0000000000000000 pthread_attr_init - 4 -000000000022 001300000002 R_X86_64_PC32 0000000000000000 pthread_attr_get_np - 4 +000000000022 001300000004 R_X86_64_PLT32 0000000000000000 pthread_attr_get_np - 4 000000000046 001400000004 R_X86_64_PLT32 0000000000000000 pthread_attr_getstack - 4 00000000004e 001500000004 R_X86_64_PLT32 0000000000000000 pthread_attr_destroy - 4 @@ -170,7 +170,7 @@ Symbol table '.symtab' contains 22 entri 16: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND _GLOBAL_OFFSET_TABLE_ 17: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND pthread_self 18: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND pthread_attr_init - 19: 0000000000000000 0 NOTYPE GLOBAL HIDDEN UND pthread_attr_get_np + 19: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND pthread_attr_get_np 20: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND pthread_attr_getstack 21: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND pthread_attr_destroy %% Index: www/firefox-devel/files/patch-js-src-Makefile.in =================================================================== --- www/firefox-devel/files/patch-js-src-Makefile.in (revision 430) +++ www/firefox-devel/files/patch-js-src-Makefile.in (working copy) @@ -1,9 +1,10 @@ --- js/src/Makefile.in.orig 2009-05-11 15:21:19.000000000 +0200 +++ js/src/Makefile.in 2009-05-11 15:21:34.000000000 +0200 -@@ -427,7 +427,7 @@ +@@ -427,7 +427,8 @@ endif # WINNT ifeq ($(OS_ARCH),FreeBSD) ++DEFINES += -DFREEBSD -EXTRA_LIBS += -pthread +EXTRA_LIBS += -pthread -lc endif Index: www/firefox-devel/files/patch-js-src-jsnativestack.cpp =================================================================== --- www/firefox-devel/files/patch-js-src-jsnativestack.cpp (revision 0) +++ www/firefox-devel/files/patch-js-src-jsnativestack.cpp (revision 0) @@ -0,0 +1,12 @@ +--- js/src/jsnativestack.cpp~ ++++ js/src/jsnativestack.cpp +@@ -50,7 +50,8 @@ + #elif defined(XP_MACOSX) || defined(DARWIN) || defined(XP_UNIX) + # include + +-# if defined(__FreeBSD__) ++# if defined(FREEBSD) ++# include + # include + # endif + %%