Date: Mon, 19 Sep 2011 08:47:25 -0400 From: "b. f." <bf1783@googlemail.com> To: freebsd-ports@FreeBSD.org, "Conrad J. Sabatier" <conrads@cox.net> Subject: Re: Ports with CPPFLAGS in CONFIGURE_(ARGS|ENV) Message-ID: <CAGFTUwMn0-B9WW4XUrhx7ZmPOKKEtxKjn5s6z3zOwFif%2BMUm1Q@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
> > > Do you mean one gigantic, monolithic patch that would amend all of > > > them, or a large set of individual patches (last I checked, there > > > were ~1453 ports in need of this sort of revision)? =C2=A0I could go > > > either way, just need to know which would be preferred. > > > > One monolithic patch (preferably generated with "cvs diff -Nu") > > OK. Just a few more questions: > > portlint -A issues no warning in the case of CPPFLAGS being added to > CONFIGURE_ARGS. Should I concern myself only with CONFIGURE_ENV, or > would it be best to modify in either case? Either case. There are slight differences in the handling of variables passed in the environment (as is done by default for CPPFLAGS), and variables passed on the command-line (as is done for variables assigned in CONFIGURE_ARGS), but they are usually unimportant. Most occurrences of CPPFLAGS in CONFIGURE_ARGS are either mistakes or anachronisms. > > Also, is there any possibility of either CONFIGURE_ENV or > CONFIGURE_ARGS being used in some non-standard fashion, i.e., with > anything other than a GNU configure script, meaning they should just be > left alone? Of course that is possible, although such a usage would probably be rare, i= f it occurs at all. You should only be concerned about the case when: --HAS_CONFIGURE is defined (note that HAS_CONFIGURE can be implied by other things, like GNU_CONFIGURE, XORG_CAT, USE_AUTOTOOLS, USE_PHPIZE, and USE_PHPEXT); and --the default "do-configure" target has not been overridden; because that is when CPPFLAGS is passed in the environment to the configure script. See bsd.port.mk. b.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGFTUwMn0-B9WW4XUrhx7ZmPOKKEtxKjn5s6z3zOwFif%2BMUm1Q>