From owner-freebsd-stable@FreeBSD.ORG  Tue Mar  6 10:20:30 2012
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CF3CB1065785;
	Tue,  6 Mar 2012 10:20:30 +0000 (UTC) (envelope-from bsd@kobyla.org)
Received: from kobyla.org (out.kobyla.org [109.206.180.180])
	by mx1.freebsd.org (Postfix) with ESMTP id 3652C8FC0C;
	Tue,  6 Mar 2012 10:20:29 +0000 (UTC)
Received: from cel.home (ask1@localhost [127.0.0.1])
	by kobyla.org (8.14.5/8.14.5) with ESMTP id q26AK3uP029499;
	Tue, 6 Mar 2012 12:20:04 +0200 (EET) (envelope-from bsd@kobyla.org)
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
References: <op.v9l1byf89gyv16@pp>
	<CAJ-FndAFMV2iHcMKvMruCP+HRzwQuY1Jcd_o6ZEnTCiPV8_8oA@mail.gmail.com>
To: "Pavel Polyakov" <bsd@kobyla.org>, "Attilio Rao" <attilio@freebsd.org>
Date: Tue, 06 Mar 2012 12:20:03 +0200
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "Pavel Polyakov" <bsd@kobyla.org>
Message-ID: <op.waqux6rr9gyv16@cel.home>
In-Reply-To: <CAJ-FndAFMV2iHcMKvMruCP+HRzwQuY1Jcd_o6ZEnTCiPV8_8oA@mail.gmail.com>
User-Agent: Opera Mail/11.61 (FreeBSD)
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.6
	(kobyla.org [127.0.0.1]); Tue, 06 Mar 2012 12:20:06 +0200 (EET)
Cc: stable@freebsd.org, daichi@freebsd.org
Subject: Re: lock violation in unionfs (9.0-STABLE r230270)
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Mar 2012 10:20:30 -0000

>> mount -t unionfs -o noatime /usr /mnt
>>
>> insmntque: mp-safe fs and non-locked vp: 0xfffffe01d96704f0 is not
>> exclusive locked but should be
>> KDB: enter: lock violation
>
> Pavel,
> can you give a spin to this patch?:
> http://www.freebsd.org/~attilio/unionfs_missing_insmntque_lock.patch
>
> I think that the unlocking is due at that point as the vnode lock can
> be switch later on.
>
> Let me know what you think about it and what the test does.

Thanks!
This patch fixes the problem with lock violation. Sorry I've tested it so
late.