Date: Wed, 29 May 2013 19:48:47 +0200 From: Emanuel Haupt <ehaupt@critical.ch> To: Emanuel Haupt <ehaupt@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r319384 - head/mail/milter-callback Message-ID: <20130529194847.2738e8fc165db5f658a2d54e@critical.ch> In-Reply-To: <201305291735.r4THZowZ077077@svn.freebsd.org> References: <201305291735.r4THZowZ077077@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Emanuel Haupt <ehaupt@FreeBSD.org> wrote: > Author: ehaupt > Date: Wed May 29 17:35:50 2013 > New Revision: 319384 > URL: http://svnweb.freebsd.org/changeset/ports/319384 > > Log: > Fix build on HEAD by setting USE_GCC=any which I believe is better > than marking it BROKEN if clang is detected. In order to do that > handle do-build target since the distribution Makefile includes > <bsd.prog.mk> which does not handle USE_GCC=any well. Question about that: What about making this standard policy for ports that don't build with clang? There is for instance sysutils/lsof which blocks archivers/tardy in a CC=clang environment. How about setting all the ports that fail to build with clang to USE_GCC=any and then fix them on them gradually? Emanuel > > Modified: > head/mail/milter-callback/Makefile > > Modified: head/mail/milter-callback/Makefile > ============================================================================== > --- head/mail/milter-callback/Makefile Wed May 29 16:52:39 > 2013 (r319383) +++ head/mail/milter-callback/Makefile > Wed May 29 17:35:50 2013 (r319384) @@ -15,16 +15,27 @@ > LIB_DEPENDS+= spf2:${PORTSDIR}/mail/libs > USE_XZ= yes > USE_RC_SUBR= milter-callback > +USE_GCC= any > > SUB_FILES= pkg-message > MAN8= milter-callback.8 > > -MAKE_ENV+= WITH_SPF=yes > MAKE_JOBS_SAFE= yes > > -.if ${CC} == "clang" || ${CXX} == "clang++" > -BROKEN= does not build with clang, uses nested functions > -.endif > +SRC_FILES= cache.c commonprocs.c cpit.c dealwithmxes.c > detectlamespf. > + makedecision.c mcspf.c milter-callback.c pgupdate.c \ > + processdirectpart.c processmxpart.c pushhistory.c > sigusr1.c + > +CFLAGS+= -DFREEBSD -DHAVE_NS_TYPE -DWITH_SPF -I > ${LOCALBASE}/include \ > + -I${WRKSRC} -std=gnu99 > +LDFLAGS+= -lmilter -lthr -L${LOCALBASE}/lib -lspf2 > + > +do-build: > +.for f in ${SRC_FILES} > + ${CC} ${CFLAGS} -c ${WRKSRC}/${f} -o ${WRKSRC}/${f:C/\.c/.o/} > +.endfor > + ${CC} ${LDFLAGS} ${SRC_FILES:C/(.*)\.c/${WRKSRC}\/\1.o/} \ > + -o ${WRKSRC}/${PORTNAME} > > post-patch: > @${REINPLACE_CMD} -e "s|/usr/local|${PREFIX}|" \ >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130529194847.2738e8fc165db5f658a2d54e>