From owner-freebsd-net@FreeBSD.ORG Tue Dec 2 01:04:43 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40C68106564A for ; Tue, 2 Dec 2008 01:04:43 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.187]) by mx1.freebsd.org (Postfix) with ESMTP id CF20C8FC19 for ; Tue, 2 Dec 2008 01:04:42 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by ti-out-0910.google.com with SMTP id a1so1648658tib.3 for ; Mon, 01 Dec 2008 17:04:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from :to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=6edhwiMC2g8Id56ET+wobKPQA899Yn+h9lNoXsbg0CQ=; b=Fgbw/mlfhyHPFftNGJuVmIAkMN+4ehtN4fJGqKNY1aRFAE3kEZCidssACQBfnN/I2h 6oHtuMj9HPCxAH4PYL9W0doFuX46CAcnYteCki3LXVJh1IC85tV9Ldy0x6RTN+xb2Ohy cutqPVtk/0+v7jChrFDS5pRS9Y5kSxMfnHII0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=KRaSAtQvkT8ngySnmkjZ9kOtkZ5gQQ2V8uiI0UlAj7fbnHseTzKS/vpoEd/6dare/0 rGzI5iVb6wP16jm2LggTEFeUL+y0Q3RXve1+ZNmlIKPO58BcQoEOitxx05ywTjfoU3KT TsXvNcdy6DmXEYApXWnXNgTvhelqmJcoVKVXM= Received: by 10.110.62.4 with SMTP id k4mr17242259tia.17.1228179881603; Mon, 01 Dec 2008 17:04:41 -0800 (PST) Received: from michelle.cdnetworks.co.kr ([211.53.35.84]) by mx.google.com with ESMTPS id y3sm2394872tia.6.2008.12.01.17.04.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 01 Dec 2008 17:04:40 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id mB214VcY005551 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 2 Dec 2008 10:04:31 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id mB214VZA005550; Tue, 2 Dec 2008 10:04:31 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 2 Dec 2008 10:04:31 +0900 From: Pyun YongHyeon To: Andrew Message-ID: <20081202010431.GA5306@cdnetworks.co.kr> References: <54854a7a0811291918s7affc753k998607f2529e7c2e@mail.gmail.com> <20081201043218.GB1082@cdnetworks.co.kr> <54854a7a0812011650i345884f5t257c066604d42e65@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54854a7a0812011650i345884f5t257c066604d42e65@mail.gmail.com> User-Agent: Mutt/1.4.2.1i Cc: freebsd-net@freebsd.org Subject: Re: re0: Unknown H/W revision: 0x28000000 device_attach: re0 attach returned 6 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Dec 2008 01:04:43 -0000 On Tue, Dec 02, 2008 at 12:50:07AM +0000, Andrew wrote: > 2008/12/1 Pyun YongHyeon : > > On Sun, Nov 30, 2008 at 03:18:41AM +0000, Andrew Tulloch wrote: > > > I've just installed from the FreeBSD 7.1-BETA1 iso and get the > > > following when the re driver attempts to attach to the two onboard > > > NICs found on a Gigabyte GA-EX58-UD5 motherboard: > > > > > > re0: > > Ethernet> port 0x9e00-0x9eff mem > > > 0xfd3ff000-0xfd3fffff,0xfd3f8000-0xfd3fbfff irq 16 at device 0.0 on > > > pci8 > > > re0: Chip rev. 0x28000000 > > > re0: MAC rev. 0x00100000 > > > re0: Unknown H/W revision: 0x28000000 > > > device_attach: re0 attach returned 6 > > > pcib9: irq 17 at device 28.5 on pci0 > > > pci9: on pcib9 > > > re1: > > Ethernet> port 0x8e00-0x8eff mem > > > 0xfd1ff000-0xfd1fffff,0xfd1f8000-0xfd1fbfff irq 17 at device 0.0 on > > > pci9 > > > re1: Chip rev. 0x28000000 > > > re1: MAC rev. 0x00100000 > > > re1: Unknown H/W revision: 0x28000000 > > > device_attach: re1 attach returned 6 > > > > > > pciconf -lvc extract: > > > re0@pci0:8:0:0: class=0x020000 card=0xe0001458 chip=0x816810ec rev=0x03 hdr=0x00 > > > vendor = 'Realtek Semiconductor' > > > device = 'RTL8168/8111 PCI-E Gigabit Ethernet NIC' > > > class = network > > > subclass = ethernet > > > cap 01[40] = powerspec 3 supports D0 D1 D2 D3 current D0 > > > cap 05[50] = MSI supports 1 message, 64 bit > > > cap 10[70] = PCI-Express 2 endpoint IRQ 0 > > > cap 11[ac] = MSI-X supports 4 messages in map 0x20 > > > cap 03[cc] = VPD > > > re1@pci0:9:0:0: class=0x020000 card=0xe0001458 chip=0x816810ec rev=0x03 hdr=0x00 > > > vendor = 'Realtek Semiconductor' > > > device = 'RTL8168/8111 PCI-E Gigabit Ethernet NIC' > > > class = network > > > subclass = ethernet > > > cap 01[40] = powerspec 3 supports D0 D1 D2 D3 current D0 > > > cap 05[50] = MSI supports 1 message, 64 bit > > > cap 10[70] = PCI-Express 2 endpoint IRQ 0 > > > cap 11[ac] = MSI-X supports 4 messages in map 0x20 > > > cap 03[cc] = VPD > > > > > > > > > Is there any simple patch I can apply to get the driver to attach, > > > assuming it should work? > > > > > > > This controller seems to support MSI-X with 4 messages. > > Unfortunately previous PCIe controllers from RealTek were notorious > > for MSI issues so it's hard to know this revision really works with > > MSI-X. I guess it was added to support RSS(receive-side scaling of > > MS NDIS 6.0). > > As sephe said if the controller configuration is the same as 8168C > > family, the attached patch would make re(4) work as expected. > > > > -- > > Regards, > > Pyun YongHyeon > > > > Pyun, > I applied the patch, but it didn't attach initially, I added an extra > entry to re_hwrevs as that seemed to be what was missing and it > attached and seems to function (as far as a quick ping test and make > update). Changes I made to if_re.c attached. If you have anything to > try for MSI-X I can probably test those. > You're right. I've missed to update revision entry. :-) I guess MSI-X requires a documentation from RealTek as it may have to map interrupt source to MSI-X vectors. It may also need to map PBA to MSI-X work on 8168D. Would you show me dmesg output of re(4)? Thanks for the patch and testing! -- Regards, Pyun YongHyeon