From owner-freebsd-current@FreeBSD.ORG Mon Oct 8 07:05:12 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85D3916A469 for ; Mon, 8 Oct 2007 07:05:12 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 324AE13C481 for ; Mon, 8 Oct 2007 07:05:12 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 8D05841C756; Mon, 8 Oct 2007 09:05:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id 4VjG0hZoDdX5; Mon, 8 Oct 2007 09:05:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 128CA41C752; Mon, 8 Oct 2007 09:05:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id D5053444885; Mon, 8 Oct 2007 07:04:32 +0000 (UTC) Date: Mon, 8 Oct 2007 07:04:32 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Pyun YongHyeon In-Reply-To: <20071008061758.GF46694@cdnetworks.co.kr> Message-ID: <20071008070345.E6043@maildrop.int.zabbadoz.net> References: <20071008061758.GF46694@cdnetworks.co.kr> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-current@FreeBSD.org Subject: Re: CFT: vr(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2007 07:05:12 -0000 On Mon, 8 Oct 2007, Pyun YongHyeon wrote: > It seems that there had been several stability issues in vr(4). > Here is mimimal patch that make vr(4) work reliably under heavy > network loads. The patch does the following: > - Always check writability of mbuf before padding and make a > writable copy of the mbuf if mbuf is marked as read-only. > - Before padding is done check remaining bytes such that it can > safely extend buffer size of the mbuf. > - Before padding always check the return value of m_defrag(9). > - Zero out pad space to avoid leaking data. > > If you have vr(4) hardware please give it spin and let me know > the result. Had you seen wpaul's posting to net@ a few weeks ago. That had a patch attached as well. What about that? -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time.