Date: Thu, 17 Aug 2017 12:16:22 +0200 From: Christian Ullrich <chris@chrullrich.net> To: Kyle Evans <kevans@FreeBSD.org> Cc: svn-src-stable@freebsd.org, freebsd-stable@freebsd.org Subject: Re: svn commit: r322609 - in stable/11: contrib/netbsd-tests/usr.bin/grep usr.bin/grep Message-ID: <0cf58b0e-51cd-27f9-1ce5-87ee0e8df207@chrullrich.net> In-Reply-To: <201708170426.v7H4Q4SL015844@repo.freebsd.org> References: <201708170426.v7H4Q4SL015844@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Kyle Evans wrote: > Author: kevans > Date: Thu Aug 17 04:26:04 2017 > New Revision: 322609 > URL: https://svnweb.freebsd.org/changeset/base/322609 > > Log: > MFC r318571: bsdgrep: emit more than MAX_LINE_MATCHES per line > Modified: stable/11/usr.bin/grep/util.c > ============================================================================== > --- stable/11/usr.bin/grep/util.c Thu Aug 17 04:18:31 2017 (r322608) > +++ stable/11/usr.bin/grep/util.c Thu Aug 17 04:26:04 2017 (r322609) > @@ -356,11 +366,11 @@ procline(struct parsec *pc) > { > regmatch_t pmatch, lastmatch, chkmatch; > wchar_t wbegin, wend; > - size_t st = 0, nst = 0; > + size_t st, nst; > unsigned int i; > int c = 0, r = 0, lastmatches = 0, leflags = eflags; > size_t startm = 0, matchidx; > - int retry; > + unsigned int retry; /usr/src/usr.bin/grep/util.c:453:26: error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare] pmatch.rm_so + 1 < retry)) ~~~~~~~~~~~~~~~~ ^ ~~~~~ Why would that fail after MFC? Doesn't head use -Werror too? # uname -a FreeBSD infra-poudriere 11.1-PRERELEASE FreeBSD 11.1-PRERELEASE #0 r[unhelpful]: Thu Jul 13 15:30:11 CEST 2017 toor@infra11build:/usr/obj/usr/src/sys/LOCAL amd64 ]# cc --version FreeBSD clang version 4.0.0 (tags/RELEASE_400/final 297347) (based on LLVM 4.0.0) Target: x86_64-unknown-freebsd11.1 Thread model: posix InstalledDir: /usr/bin -- Christian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0cf58b0e-51cd-27f9-1ce5-87ee0e8df207>