From owner-cvs-sbin Sat May 10 10:38:11 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA13219 for cvs-sbin-outgoing; Sat, 10 May 1997 10:38:11 -0700 (PDT) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id KAA13208; Sat, 10 May 1997 10:38:02 -0700 (PDT) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.8.5/8.8.5) with SMTP id SAA01828; Sat, 10 May 1997 18:38:02 +0100 (BST) Date: Sat, 10 May 1997 18:38:02 +0100 (BST) From: Doug Rabson To: Peter Wemm cc: CVS-committers@freebsd.org, cvs-all@freebsd.org, cvs-sbin@freebsd.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c ifconfig.h ifmedia.c In-Reply-To: <199705101714.KAA27483@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sbin@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Sat, 10 May 1997, Peter Wemm wrote: > peter 97/05/10 10:14:54 > > Modified: sbin/ifconfig ifconfig.c ifconfig.h ifmedia.c > Log: > Clean up some more. Move parsing of sysctl iflist data into a single > place rather than updating the main loop's index variables from within > a subroutine and other revolting things like that. Move some more > globals into local variables. I once tried to fix some bugs in a program which had three global variables, i, j and k. It used these all over the place for loop variables and often changed them in subroutines. It was 'fun' trying to figure out the control flow... -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891