Date: Thu, 14 Jan 2016 16:51:22 +0000 From: Steven Hartland <steven@multiplay.co.uk> To: John Baldwin <jhb@freebsd.org>, NGie Cooper <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi Message-ID: <5697D20A.9050309@freebsd.org> In-Reply-To: <8690606.xvPx6EyIfQ@ralph.baldwin.cx> References: <201601140922.u0E9M1rV025146@repo.freebsd.org> <F3E05332-F6B1-4685-812A-FD2BBB870075@gmail.com> <8690606.xvPx6EyIfQ@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/01/2016 15:55, John Baldwin wrote: > On Thursday, January 14, 2016 01:27:51 AM NGie Cooper wrote: >>> On Jan 14, 2016, at 01:22, Steven Hartland <smh@FreeBSD.org> wrote: >>> >>> Author: smh >>> Date: Thu Jan 14 09:22:01 2016 >>> New Revision: 293903 >>> URL: https://svnweb.freebsd.org/changeset/base/293903 >>> >>> Log: >>> Fix GCC warnings causing build failure after r293724 >>> >>> Disable some compiler warnings for GCC (non-standard compiler) fixing >>> build failures introduced by r293724, which enabled WARNS in the EFI boot >>> code, when compiling with none standard compiler (GCC). >> Disabling warnings is wrong. Here’s how arm could be fixed: >> >> $ svn diff sys/boot/ >> Index: sys/boot/common/bootstrap.h >> =================================================================== >> --- sys/boot/common/bootstrap.h (revision 293877) >> +++ sys/boot/common/bootstrap.h (working copy) >> @@ -32,6 +32,7 @@ >> #include <sys/types.h> >> #include <sys/queue.h> >> #include <sys/linker_set.h> >> +#include <time.h> >> >> /* >> * Generic device specifier; architecture-dependant >> @@ -332,12 +333,8 @@ >> extern struct arch_switch archsw; >> >> /* This must be provided by the MD code, but should it be in the archsw? */ >> -void delay(int delay); >> - > The comment seems to be related to delay() so it should perhaps go as well? > delay is actually provided by libefi but nothing else in sys/boot, so I cant see why this was ever needed, possibly a hang over?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5697D20A.9050309>