From owner-svn-src-head@freebsd.org  Fri Dec 30 18:39:22 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 927C8C974F0;
 Fri, 30 Dec 2016 18:39:22 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 72E4715C3;
 Fri, 30 Dec 2016 18:39:22 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 3725710A746;
 Fri, 30 Dec 2016 13:39:21 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Alexander Kabaev <kan@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r310789 - head/lib/libpam/static_libpam
Date: Fri, 30 Dec 2016 10:38:26 -0800
Message-ID: <2270028.8V7VsJ8Web@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; )
In-Reply-To: <201612292130.uBTLUqus011628@repo.freebsd.org>
References: <201612292130.uBTLUqus011628@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Fri, 30 Dec 2016 13:39:21 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Dec 2016 18:39:22 -0000

On Thursday, December 29, 2016 09:30:52 PM Alexander Kabaev wrote:
> Author: kan
> Date: Thu Dec 29 21:30:52 2016
> New Revision: 310789
> URL: https://svnweb.freebsd.org/changeset/base/310789
> 
> Log:
>   Use compiler driver to build relocatable object
>   
>   This works better with external toolchains where LD
>   will not necessarily defailt to emulation we want.
>   Compiler driver knows better.

I think this was the case I had added the XLDFLAGS in my mips cross-building
patches for.  I'm fine with dropping the XLDFLAGS bits and depending on the
compiler driver if we think that is the better solution.

> Modified:
>   head/lib/libpam/static_libpam/Makefile
> 
> Modified: head/lib/libpam/static_libpam/Makefile
> ==============================================================================
> --- head/lib/libpam/static_libpam/Makefile	Thu Dec 29 21:06:31 2016	(r310788)
> +++ head/lib/libpam/static_libpam/Makefile	Thu Dec 29 21:30:52 2016	(r310789)
> @@ -64,6 +64,6 @@ CLEANFILES+=	openpam_static.o \
>  		openpam_static_modules.o
>  
>  openpam_static_modules.o: openpam_static.o ${STATIC_MODULES}
> -	${LD} -o ${.TARGET} -r --whole-archive ${.ALLSRC}
> +	${CC} -nostdlib ${CFLAGS} -o ${.TARGET} -r -Wl,--whole-archive ${.ALLSRC}
>  
>  .include "${.CURDIR}/../libpam/Makefile"
> 


-- 
John Baldwin