Date: Fri, 5 Jun 2009 10:24:31 +0400 From: Stanislav Sedov <stas@FreeBSD.org> To: Benno Rice <benno@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193475 - head/sbin/kldload Message-ID: <20090605102431.4769115f.stas@FreeBSD.org> In-Reply-To: <200906042343.n54Nh8c5008164@svn.freebsd.org> References: <200906042343.n54Nh8c5008164@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Fri__5_Jun_2009_10_24_31_+0400_HLu=XRsZkM+87Tc/
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, 4 Jun 2009 23:43:08 +0000 (UTC)
Benno Rice <benno@FreeBSD.org> mentioned:
> + if (path =3D=3D NULL) {
> + err(1, "allocating %lu bytes for the path",
> + (unsigned long)pathlen + 1);
^^^^^^^^^^^^^^^^^^^^^^
Why convert pathlen to unsigned long here? The pathlen variable is
of size_t type which is already unsigned and we have the special 'z' prefix
in printf(3) to print those.
--=20
Stanislav Sedov
ST4096-RIPE
--Signature=_Fri__5_Jun_2009_10_24_31_+0400_HLu=XRsZkM+87Tc/
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
iQIcBAEBAgAGBQJKKLofAAoJEKN82nOYvCd04AwQAK1jmNo+1B8kYedEyHpLgfWY
ygHUgNOTuTRxBAByEhv8usOPr8kYo0eWg6wBGjfhaqoxf3Au8qZnhFtF37DqYLVE
Fzoy1JIuJrAtKpcFhiKUkZ9Hi8PYSJOhuAI+KzKbGb7GgYB3UssKchBWNcXUI4fV
L7Mmy3EMh4FEFJ9vHZpF6WTze5J/05aZs0Z6cPAk9rQNDOoGZ2NloqVVNQixGzPg
fUruoY0CbZoniWodr5Icswqx+C5cBy/5Nev5ZksFAQROJhv9xIWuTNlmz+BJwdja
I0ByYLcDmhXA3XqvdnDVaydJhEiwXH82MFsygFH6IT9CgGGxZ95WFRDJbf7GGvkw
rnmmPb1Si8pFW3hIkNSZPR9Sl0vFxx8pAUmF0l9Yh6Xn7fkDezL6NmSpjqRamjd7
1FwxOqGZiPcEdohTqn3Br+1rgDtyMdc6IASmDAgbUg8uffGemKAQQ5bBjbeemEOb
/61wq6vqpLXcmh0u45lFkEKuKHY+nMI5tyam7SJdG4/ys/WyOhwYYfxQs4EmvOf/
P05Za+UxyHXBS40S8UAT1M69lqURilUjXYcK/sGV+ABWNbxP0fRs81XswP7108NQ
VlBd9Fn9d4tOIh1fjcLptlO4qvjaDToIYD36BCjjFxBdIKsFDAHT4gbGB+1Hn12W
LaABYjRA7gxManMudROL
=ww/W
-----END PGP SIGNATURE-----
--Signature=_Fri__5_Jun_2009_10_24_31_+0400_HLu=XRsZkM+87Tc/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090605102431.4769115f.stas>