Date: Thu, 12 Nov 2015 02:12:25 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r401299 - head/security/openssh-portable/files Message-ID: <20151112021225.GB43902@FreeBSD.org> In-Reply-To: <201511112121.tABLLjO6051679@repo.freebsd.org> References: <201511112121.tABLLjO6051679@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 11, 2015 at 09:21:45PM +0000, Bryan Drewery wrote: > New Revision: 401299 > URL: https://svnweb.freebsd.org/changeset/ports/401299 > > Log: > Make portlint stop spamming me. It's gotten quite silly. I hope this is a temporary measure, even though portlint(1) can indeed get annoying at times. That said, I still don't see the problem with simply ignoring warnings that do not apply in certain particular case. > WARN: /root/svn/ports/security/openssh-portable/files/patch-auth.c: > patch was not generated using ``make makepatch''. It is recommended > to use ``make makepatch'' when you need to [re-]generate a patch to > ensure proper patch format. As John had said on IRC, this helps to get consistent patches, because prople rarely think about these little details ("repo churn? who cares about it") and portlint(1) warning gives them simple and straight course of action. Yet it's true that the check could probably be made somewhat smarter than simple grepping for "UTC". TL;DR: instead of adding noise to the patches, it's better to improve portlint(1). Or learn how to ignore its warnings. ;-) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151112021225.GB43902>