Date: Thu, 19 Jul 2018 13:59:49 -0600 From: Ian Lepore <ian@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Michael Tuexen <tuexen@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336503 - in head/sys: netinet netinet6 Message-ID: <1532030389.1344.9.camel@freebsd.org> In-Reply-To: <20180719195302.GA26853@FreeBSD.org> References: <201807191933.w6JJXhof018383@repo.freebsd.org> <20180719195302.GA26853@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2018-07-19 at 19:53 +0000, Alexey Dokuchaev wrote: > > +++ head/sys/netinet/sctp_asconf.c Thu Jul 19 19:33:42 2018 (r336503) > > static struct mbuf * > > -sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8_t *error_tlv, > > +sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8_t * error_tlv, > > This looks strange now. In C, asterisk is usually placed by the variable. "usually" may be true of freebsd, but most places I've worked consider the * (and & in c++) to be more associated with the type being declared than with the variable name, thus they get snugged up against the type info, not the var name. Putting the * or & with the var name leads to particularly bad constructs such as int a, *b; which, for maximal clarity, should be: int a; int* b; -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1532030389.1344.9.camel>