From owner-svn-src-all@freebsd.org Fri Oct 28 15:32:06 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E7DFC2534F; Fri, 28 Oct 2016 15:32:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B4174FC3; Fri, 28 Oct 2016 15:32:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u9SFVxgH053357 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 28 Oct 2016 18:31:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u9SFVxgH053357 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u9SFVwt1053356; Fri, 28 Oct 2016 18:31:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 28 Oct 2016 18:31:58 +0300 From: Konstantin Belousov To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307971 - head/sys/mips/include Message-ID: <20161028153158.GD54029@kib.kiev.ua> References: <201610261737.u9QHb8Ps036831@repo.freebsd.org> <11698910.Akp5I7OyZ5@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11698910.Akp5I7OyZ5@ralph.baldwin.cx> User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 15:32:06 -0000 On Thu, Oct 27, 2016 at 03:08:01PM -0700, John Baldwin wrote: > On Wednesday, October 26, 2016 05:37:08 PM John Baldwin wrote: > > Author: jhb > > Date: Wed Oct 26 17:37:08 2016 > > New Revision: 307971 > > URL: https://svnweb.freebsd.org/changeset/base/307971 > > > > Log: > > Correct definition of 'struct sigcontext' on MIPS. > > > > Add missing fields ('sr' and 'mc_tls') to 'struct sigcontext'. > > > > The kernel doesn't use 'struct sigcontext' but instead uses 'ucontext_t' > > which includes 'mcontext_t' in 'struct sigframe' to build the signal frame. > > As a result, this change is not an ABI change but simply making > > 'struct sigcontext' correct. Note that 'struct sigcontext' is only used > > for "Traditional BSD style" signal handlers. > > > > While here, rename the 'xxx' field to '__spare__' to match 'mcontext_t'. > > > > Sponsored by: DARPA, AFRL > > We should perhaps a static assertion somewhere that > sizeof(sigset_t) + sizeof(ucontext_t) == sizeof(struct sigcontext) if > that is really true of all of our architectures. This should be mcontext_t instead of ucontext_t. > > Alternatively, we might consider retiring 'struct sigcontext' altogether. > It's purpose has been superseded by SA_SIGINFO (which is more portable) > which has been around for quite a while now. As a first step I guess > we could try an exp-run with 'struct sigcontext' removed. (We should > have ditched this in 5.0 since we have a separate sendsig/sigreturn path > for FreeBSD 4.x already. Oh well.) I do not think that this is a practical option. I know that struct sigcontext is used by nongnu libunwind. Quick search identifies mono and go as consumers as well.