Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Feb 2014 07:18:53 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r261579 - stable/10/sys/dev/usb
Message-ID:  <201402070718.s177IrCb077680@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Fri Feb  7 07:18:52 2014
New Revision: 261579
URL: http://svnweb.freebsd.org/changeset/base/261579

Log:
  MFC r261505:
  Fix a regression issue. Contiguous single segment allocations above
  PAGE_SIZE bytes should only use one USB page structure. Fixes a
  problem with some external drivers.

Modified:
  stable/10/sys/dev/usb/usb_busdma.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/usb/usb_busdma.c
==============================================================================
--- stable/10/sys/dev/usb/usb_busdma.c	Fri Feb  7 05:23:04 2014	(r261578)
+++ stable/10/sys/dev/usb/usb_busdma.c	Fri Feb  7 07:18:52 2014	(r261579)
@@ -454,7 +454,7 @@ usb_pc_common_mem_cb(void *arg, bus_dma_
 		goto done;
 	}
 #endif
-	while (1) {
+	while (pc->ismultiseg) {
 		off += USB_PAGE_SIZE;
 		if (off >= (segs->ds_len + rem)) {
 			/* page crossing */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402070718.s177IrCb077680>