Date: Sat, 13 Jul 2013 23:27:42 +0300 From: Mikolaj Golub <trociny@FreeBSD.org> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, Marko Zec <zec@fer.hr> Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130713202741.GB2832@gmail.com> In-Reply-To: <CAG=rPVdW3320YaLbx%2BsWd8-Cp6x8fH7498oN9UWsX6y%2BA=gdew@mail.gmail.com> References: <CAJ-Vmomv1nEEq9HV9GreQg6KJGos6ffDhFcVUsUuzfCL6h-YQw@mail.gmail.com> <CAJ-Vmokm29XXbQr5uTwEbGGDYo-8WQNsp60b%2B7Khkteyh%2BO%2B6A@mail.gmail.com> <CAJ-VmomidFufKmGUb0YP2pHWu%2BpF2Os3Fo4JWzkMJDKLqP_ing@mail.gmail.com> <20130713073118.GC2757@gmail.com> <CAG=rPVe_F03LTt1K77p1BSw0hojMm-Ms-oZdhaFgo842AxkmhQ@mail.gmail.com> <20130713111825.GE2757@gmail.com> <20130713141802.GG2757@gmail.com> <CAG=rPVdhjX0SV44vSVTbXq2CAB8xn2%2BXaGW0ywhYJDd9M3tZ5A@mail.gmail.com> <20130713183354.GA2832@gmail.com> <CAG=rPVdW3320YaLbx%2BsWd8-Cp6x8fH7498oN9UWsX6y%2BA=gdew@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 13, 2013 at 12:45:13PM -0700, Craig Rodrigues wrote: > OK, just to double check, based on reading your post: > http://lists.freebsd.org/pipermail/svn-src-all/2013-July/071848.html , > with Marko's kldload/kldunload change, you encountered kernel panics in PF > and IPFW? Yes. Also in lagg :( > I also encountered kernel panics in PF with that patch. > Maybe we can clean up those modules in a separate pass, > and apply the kldload/kldunload fix some time in the future. > > > > > > > > Concerning your combined patch, as I said previously I don't like very > > much that dance with is_default_vnet. What is a purpose of it? As for > > me, it only makes the code less readable. I would just set curvnet to > > vnet0, as it is in Marko's patch. > > > > Fine by me. I have re-rolled my combined patch to remove the > is_default_vnet check > and go with Marko's code to set curvnet to vnet0: > > (1) Combine Adrian and Marko's patches, but omit Marko's changes to > kldload/kldunload: > > http://people.freebsd.org/~rodrigc/vnet-patch-adrian+marko-p2.txt > > (2) Revert my Bluetooth patch: > > http://people.freebsd.org/~rodrigc/patch-revert-GRN-253255.txt Thanks. -- Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130713202741.GB2832>