Date: Thu, 26 Mar 2015 17:39:50 -0700 From: Craig Rodrigues <rodrigc@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, freebsd-toolchain@freebsd.org Subject: Re: Failed to build with external toolchain Message-ID: <CAG=rPVfW8bm9_SkDrskPZ=R07aQDNj-s28wmW=3%2B58xp%2B-Rq9w@mail.gmail.com> In-Reply-To: <1A90C16A-1A23-4EFD-BB61-0E956C8CB49D@bsdimp.com> References: <CAG=rPVfP4=BuL8DOuy9FNDcN51zshfBfeuFONiAAONWON6n3kA@mail.gmail.com> <A1580F95-4882-46F3-96C2-3D3D1D493706@FreeBSD.org> <CAG=rPVd9deshQWvMXOHF%2ByfvqZfo3UOsao9iqipX_CQGKs=vHA@mail.gmail.com> <1857A2A3-0C19-4F52-BCAF-6C72FE7D8DF3@FreeBSD.org> <CAG=rPVfKTi5cFyhNBg7pSYi_rUoEw2d8NeqA89Fy%2BiLxZt86hg@mail.gmail.com> <C3173614-08B4-4616-BD76-93CA8417A044@FreeBSD.org> <CAG=rPVc=YxuakeyFL9SXAnas3e9QyozfLqC2uQ_KhkqaavRvNQ@mail.gmail.com> <B768CFD8-FDC1-48EF-91C3-92056F90EE02@bsdimp.com> <CAG=rPVfC%2BoVr35Ayp_gudkGXctYprpxW2D7tj%2BT3tOOh=OyLpg@mail.gmail.com> <1A90C16A-1A23-4EFD-BB61-0E956C8CB49D@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 26, 2015 at 11:47 AM, Warner Losh <imp@bsdimp.com> wrote: > > > On Mar 26, 2015, at 2:12 AM, Craig Rodrigues <rodrigc@FreeBSD.org> > wrote: > > OK. I have a bit of egg on my face... > > The test is for X_COMPILER_TYPE, so COMPILER_VERSION isn't relevant. It's > always outside the tree. > So your original patch is correct. Please go ahead and commit that and > accept my apologies for the wild goose chase. > Okee dokee, I committed my original patch: http://lists.freebsd.org/pipermail/svn-src-all/2015-March/101492.html No worries about geese. External toolchain support is important to the future of FreeBSD, and I appreciate your work. I'm just trying to help as best I can by testing things, reporting problems, and fixing things where I can. -- Craig
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVfW8bm9_SkDrskPZ=R07aQDNj-s28wmW=3%2B58xp%2B-Rq9w>