From owner-freebsd-hackers Sat Sep 13 22:45:50 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id WAA23327 for hackers-outgoing; Sat, 13 Sep 1997 22:45:50 -0700 (PDT) Received: from freebie.lemis.com (gregl1.lnk.telstra.net [139.130.136.133]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id WAA23318 for ; Sat, 13 Sep 1997 22:45:43 -0700 (PDT) Received: (from grog@localhost) by freebie.lemis.com (8.8.7/8.8.5) id PAA14076; Sun, 14 Sep 1997 15:15:17 +0930 (CST) Message-ID: <19970914151517.24823@lemis.com> Date: Sun, 14 Sep 1997 15:15:17 +0930 From: Greg Lehey To: Terry Lambert Cc: brian@awfulhak.org, freebsd-hackers@FreeBSD.ORG Subject: Re: rc & rc.conf References: <19970914101350.06261@lemis.com> <199709140446.VAA08907@usr08.primenet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.81e In-Reply-To: <199709140446.VAA08907@usr08.primenet.com>; from Terry Lambert on Sun, Sep 14, 1997 at 04:46:13AM +0000 Organisation: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8250 Fax: +61-8-8388-8250 Mobile: +61-41-739-7062 WWW-Home-Page: http://www.lemis.com/~grog Fight-Spam-Now: http://www.cauce.org Sender: owner-freebsd-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, Sep 14, 1997 at 04:46:13AM +0000, Terry Lambert wrote: >>> This is a disaster waiting to happen: >> >> I'm sorry, I must be too stupid. What's wrong with that? And how >> does your fix fix it? Since the flags and the -enable have been >> separated, it seems that we *should* insist on the exact string YES >> for the enable flags. > > 1) The logic is inverted from that of all similar code > > 2) The value "YES" means that flag values, if they should > be later desired, can't be put in the string in order > to activate the services with the requested flags, like > you can for all similar code. Yes, I'm not quite *that* stupid. We have two variables here: a -flags which is set with the flags, and an -enable which is set to either YES or NO. The original logic says "don't do it unless -enable is YES". Brian's saying "do it unless -enable is NO". I don't see an advantage in doing it this way, and I certainly don't see a disaster waiting to happen in the old way. Another thing that puzzles me is why somebody would want to disable cron. Greg