From owner-cvs-all@FreeBSD.ORG Wed Jun 13 22:56:19 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AB7B616A469; Wed, 13 Jun 2007 22:56:19 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from out4.smtp.messagingengine.com (out4.smtp.messagingengine.com [66.111.4.28]) by mx1.freebsd.org (Postfix) with ESMTP id 7D8EE13C43E; Wed, 13 Jun 2007 22:56:19 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 07E1712CC; Wed, 13 Jun 2007 18:56:19 -0400 (EDT) Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute2.internal (MEProxy); Wed, 13 Jun 2007 18:56:19 -0400 X-Sasl-enc: mvTPkpQgVSVmNAVeHG1DcXv5yEZDrv8Vkq13u1L3sRDL 1181775378 Received: from [192.168.123.18] (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTP id 570362055E; Wed, 13 Jun 2007 18:56:18 -0400 (EDT) Message-ID: <46707611.4090301@FreeBSD.org> Date: Wed, 13 Jun 2007 23:56:17 +0100 From: "Bruce M. Simpson" User-Agent: Thunderbird 1.5.0.10 (X11/20070407) MIME-Version: 1.0 To: Andrew Thompson References: <200706131858.l5DIw4Yr009448@repoman.freebsd.org> <4670464C.8060304@FreeBSD.org> <20070613205417.GA11671@heff.fud.org.nz> In-Reply-To: <20070613205417.GA11671@heff.fud.org.nz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_bridge.c if_bridgevar.h src/sbin/ifconfig ifbridge.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2007 22:56:19 -0000 Andrew Thompson wrote: > > I have priority frames mapped to vlan1 in bridge_rtupdate, as far as I > can tell this is correct. > > 2325: bridge_rtupdate(...) > 2334: /* 802.1p frames map to vlan 1 */ > 2335: if (vlan == 0) > 2336: vlan = 1; > According to the 802.1q spec this is correct for bridging. priority frames for the purposes of the VLAN bridge are regarded as untagged and should be mapped to VLAN 1 (table 9-2 in the 802.1q-1998 spec). regards, BMS