Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 31 Mar 2017 22:05:10 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r316340 - head/sbin/ifconfig
Message-ID:  <201703312205.v2VM5AOP078703@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Fri Mar 31 22:05:10 2017
New Revision: 316340
URL: https://svnweb.freebsd.org/changeset/base/316340

Log:
  [ifconfig] add some comments around missing net80211 VHT configuration.
  
  VHT STBC, A-MPDU density and A-MPDU size configuration parameters are
  different when doing VHT.

Modified:
  head/sbin/ifconfig/ifieee80211.c

Modified: head/sbin/ifconfig/ifieee80211.c
==============================================================================
--- head/sbin/ifconfig/ifieee80211.c	Fri Mar 31 21:29:43 2017	(r316339)
+++ head/sbin/ifconfig/ifieee80211.c	Fri Mar 31 22:05:10 2017	(r316340)
@@ -1758,6 +1758,7 @@ set80211shortgi(const char *val, int d, 
 		0, NULL);
 }
 
+/* XXX 11ac density/size is different */
 static void
 set80211ampdu(const char *val, int d, int s, const struct afswtch *rafp)
 {
@@ -1831,6 +1832,7 @@ DECL_CMD_FUNC(set80211ampdulimit, val, d
 	set80211(s, IEEE80211_IOC_AMPDU_LIMIT, v, 0, NULL);
 }
 
+/* XXX 11ac density/size is different */
 static
 DECL_CMD_FUNC(set80211ampdudensity, val, d)
 {
@@ -4957,6 +4959,7 @@ end:
 				break;
 			}
 		}
+		/* XXX 11ac density/size is different */
 		if (get80211val(s, IEEE80211_IOC_AMPDU_LIMIT, &val) != -1) {
 			switch (val) {
 			case IEEE80211_HTCAP_MAXRXAMPDU_8K:
@@ -4973,6 +4976,7 @@ end:
 				break;
 			}
 		}
+		/* XXX 11ac density/size is different */
 		if (get80211val(s, IEEE80211_IOC_AMPDU_DENSITY, &val) != -1) {
 			switch (val) {
 			case IEEE80211_HTCAP_MPDUDENSITY_NA:
@@ -5054,6 +5058,8 @@ end:
 			else if (verbose)
 				LINE_CHECK("-rifs");
 		}
+
+		/* XXX VHT STBC? */
 		if (get80211val(s, IEEE80211_IOC_STBC, &val) != -1) {
 			switch (val) {
 			case 0:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703312205.v2VM5AOP078703>