From owner-cvs-all Thu Oct 10 7:58:17 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82D2837B42A; Thu, 10 Oct 2002 07:58:12 -0700 (PDT) Received: from anchor-post-35.mail.demon.net (anchor-post-35.mail.demon.net [194.217.242.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1F7643F1C; Thu, 10 Oct 2002 07:57:39 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from mailgate.nlsystems.com ([62.49.251.130] helo=herring.nlsystems.com) by anchor-post-35.mail.demon.net with esmtp (Exim 3.36 #2) id 17zeks-0001xg-0U; Thu, 10 Oct 2002 15:57:38 +0100 Received: from herring (herring [10.0.0.2]) by herring.nlsystems.com (8.12.6/8.12.4) with ESMTP id g9AEvPbE071396; Thu, 10 Oct 2002 15:57:33 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Thu, 10 Oct 2002 15:57:25 +0100 (BST) From: Doug Rabson To: Peter Wemm Cc: Alfred Perlstein , , Subject: Re: cvs commit: src/sys/ia64/ia32 ia32_misc.c syscalls.master In-Reply-To: <20021009224357.7C8EA2A88D@canning.wemm.org> Message-ID: <20021010155642.K70762-100000@herring.nlsystems.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 9 Oct 2002, Peter Wemm wrote: > Alfred Perlstein wrote: > > * Alfred Perlstein [021009 15:28] wrote: > > > * Peter Wemm [021009 15:27] wrote: > > > > peter 2002/10/09 15:27:24 PDT > > > > > > > > Modified files: > > > > sys/ia64/ia32 ia32_misc.c syscalls.master > > > > Log: > > > > Try and deal with the #ifdef COMPAT_FREEBSD4 sendfile stuff. This woul > d > > > > have been a lot easier if do_sendfile() was usable externally. > > > > > > I don't object to it being made non-static. > > > > However using SCARG is depricated according to bde, shouldn't you > > just use struct->field? > > I'm really not all that sure why dfr likes it so much. :-] I don't like it - I just thought it was "the style". If its deprecated, then strip it all out - its ugly. -- Doug Rabson Mail: dfr@nlsystems.com Phone: +44 20 8348 6160 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message