From owner-freebsd-current@FreeBSD.ORG Thu Mar 26 19:33:00 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41A4B1065670 for ; Thu, 26 Mar 2009 19:33:00 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (brucec-1-pt.tunnel.tserv4.nyc4.ipv6.he.net [IPv6:2001:470:1f06:c09::2]) by mx1.freebsd.org (Postfix) with ESMTP id EE9538FC12 for ; Thu, 26 Mar 2009 19:32:59 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id 093EE19017; Thu, 26 Mar 2009 19:32:58 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on muon X-Spam-Level: X-Spam-Status: No, score=-2.6 required=8.0 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 Received: from gluon.draftnet (unknown [IPv6:2a01:348:10f:0:240:f4ff:fe57:9871]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA; Thu, 26 Mar 2009 19:32:57 +0000 (GMT) Date: Thu, 26 Mar 2009 19:32:36 +0000 From: Bruce Cran To: Lars Engels Message-ID: <20090326193236.090334d1@gluon.draftnet> In-Reply-To: <20090326191206.GA92358@e.0x20.net> References: <49BE7C5A.2080103@icyb.net.ua> <10611.1237233778@critter.freebsd.dk> <20090320074833.67d615e2@gluon> <49C37B75.5060905@andric.com> <20090320191938.25d85caa@gluon> <20090326085449.GB56137@server.vk2pj.dyndns.org> <20090326191206.GA92358@e.0x20.net> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.14.7; i386-portbld-freebsd7.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Peter Jeremy , Dimitry Andric , freebsd-current@freebsd.org Subject: Re: ata: printf on every spinup/spindown? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2009 19:33:00 -0000 On Thu, 26 Mar 2009 20:12:07 +0100 Lars Engels wrote: > On Thu, Mar 26, 2009 at 07:54:49PM +1100, Peter Jeremy wrote: > > On 2009-Mar-20 19:19:38 +0000, Bruce Cran wrote: > > >There's a reluctance to include code like this, I > > >think because it bypasses the ATA driver and talks directly to the > > >drive. Since the driver doesn't know what the drive's been told to > > >do, it can't know to adjust timers etc. to wait for the disk to > > >spin back up, for example. > > > > This code is no worse than installing sysutils/ataidle - which also > > bypasses the driver. > > > > As it stands, FreeBSD out-of-the-box behaves in a way that adversely > > impacts laptop HDD life - and correcting this requires that the > > end-user both be aware of the problem and then find, install and > > configure a port to work around this. I am very uncomfortable with > > this and would prefer to see the base system require less user > > knowledge/intervention. > > AFAIK ataidle is under the BSD license, so we could include it in the > base system. As the author I can confirm that it is BSD licensed :) Either way - including ataidle or patching atacontrol, I'd like to see a utility to set APM and AAM features at a minimum in the base system because especially with the problems on recent laptops it's something we're missing. I mentioned the reluctance to include code like it because when I initially wrote ataidle I got a bit of resistance about including it, I think from the worry that it would cause problems. There are indeed a few PRs reporting panics when spinning drives back up, but I suspect the driver is more resiliant to those issues now. -- Bruce Cran