Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Mar 2014 14:27:12 +0100
From:      Pietro Cerutti <gahr@FreeBSD.org>
To:        Max Brazhnikov <makc@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r348527 - in head/math/vtk6: . files
Message-ID:  <20140318132711.GC64859@gahrfit.gahr.ch>
In-Reply-To: <10817105.x4IFJEMSOC@mercury.ph.man.ac.uk>
References:  <201403180926.s2I9Q52f058593@svn.freebsd.org> <10817105.x4IFJEMSOC@mercury.ph.man.ac.uk>

next in thread | previous in thread | raw e-mail | index | archive | help

--hOcCNbCCxyk/YU74
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2014-Mar-18, 11:48, Max Brazhnikov wrote:
> On Tue, 18 Mar 2014 09:26:05 +0000Tue Mar 18 09:26:05 2014 Pietro Cerutti=
 wrote:
> > Author: gahr
> > Date: Tue Mar 18 09:26:05 2014
> > New Revision: 348527
> > URL: http://svnweb.freebsd.org/changeset/ports/348527
> > QAT: https://qat.redports.org/buildarchive/r348527/
> >=20
> > Log:
> >   - Update to 6.1.0
> >   - Support Qt5
> >   - Install Tcl wrapping files in a saner location
> >=20
> > Added:
> >   head/math/vtk6/files/patch-Examples-GUI-Qt-GraphicsView_CMakeLists.tx=
t   (contents, props changed)
> >   head/math/vtk6/files/patch-Wrapping-Tcl_CMakeLists.txt   (contents, p=
rops changed)
> > Deleted:
> >   head/math/vtk6/files/patch-IO-LSDyna-private_LSDynaFamily.cxx
> >   head/math/vtk6/files/patch-Wrapping-Python_CMakeLists.txt
> > Modified:
> >   head/math/vtk6/Makefile
> >   head/math/vtk6/distinfo
> >   head/math/vtk6/files/patch-GUISupport-Qt_CMakeLists.txt
> >   head/math/vtk6/pkg-plist
> >=20
> > Modified: head/math/vtk6/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/math/vtk6/Makefile	Tue Mar 18 09:16:50 2014	(r348526)
> > +++ head/math/vtk6/Makefile	Tue Mar 18 09:26:05 2014	(r348527)
> > @@ -2,21 +2,30 @@
> >  # $FreeBSD$
> > =20
> >  PORTNAME=3D	vtk
> > -PORTVERSION=3D	6.0.0
> > +PORTVERSION=3D	6.1.0
> >  CATEGORIES=3D	math graphics
> >  MASTER_SITES=3D	http://www.vtk.org/files/release/${VTK_SHORT_VER}/
> >  PKGNAMESUFFIX=3D	6
> > +DISTNAME=3D	${PORTNAME:U}-${PORTVERSION}
> > =20
> >  MAINTAINER=3D	gahr@FreeBSD.org
> >  COMMENT=3D	The Visualization Toolkit
> > =20
> >  LICENSE=3D	BSD3CLAUSE
> > =20
> > +LIB_DEPENDS=3D	libtiff.so:${PORTSDIR}/graphics/tiff \
> > +    		libpng.so:${PORTSDIR}/graphics/png \
> > +		libjpeg.so:${PORTSDIR}/graphics/jpeg \
> > +		libfreetype.so:${PORTSDIR}/print/freetype2 \
> > +		libexpat.so:${PORTSDIR}/textproc/expat2
> > +
> >  #
> >  # TODO
> >  # * Python wrap
> >  # * VTK Groups
> > =20
> > +UNIQUENAME=3D	${PKGBASE}
> > +
> >  CONFLICTS=3D	vtk-4*
> >  USE_GL=3D		gl
> >  USE_LDCONFIG=3D	${PREFIX}/lib/vtk-${VTK_SHORT_VER}
> > @@ -27,16 +36,21 @@ CXXFLAGS+=3D	-I${LOCALBASE}/include
> >  VTK_SHORT_VER=3D	${PORTVERSION:R}
> >  PLIST_SUB+=3D	VER2=3D${VTK_SHORT_VER}
> > =20
> > -WRKSRC=3D		${WRKDIR}/VTK${PORTVERSION}
> >  DOCSDIR=3D	${PREFIX}/share/doc/vtk-${VTK_SHORT_VER}
> > +DATADIR=3D	${PREFIX}/share/vtk-${VTK_SHORT_VER}
> > =20
> >  #VTK_GROUPS=3D	Imaging MPI Qt Rendering StandAlone Views
> > -VTK_GROUPS=3D	MPI Qt
> > +VTK_GROUPS=3D	MPI
> >  VTK_WRAPS=3D	Java TclTk # Python
> >  OPTIONS_GROUP=3D	Groups Wrapping
> >  OPTIONS_GROUP_Groups=3D${VTK_GROUPS}
> >  OPTIONS_GROUP_Wrapping=3D${VTK_WRAPS}
> >  OPTIONS_DEFINE=3D	Designer DOCS
> > +OPTIONS_RADIO=3D	Qt
> > +OPTIONS_RADIO_Qt=3D	Qt4 Qt5
> > +Qt_DESC=3D	Qt GUI support
> > +Qt4_DESC=3D	Qt 4 toolkit support
> > +Qt5_DESC=3D	Qt 5 toolkit support
> >  #OPTIONS_DEFAULT=3DMPI Qt Java Python TclTk Designer
>=20
> It seems you forgot to add Qt5 or Qt4 to OPTIONS_DEFAULT.

I'm not sure I want to do that. Why would you?

> Considering that vtk6 is a toolkit, it might be useful to have
> slave port for qt5 (or qt4) instead of options.

Again, why?

> btw, lib/cmake/vtk-%%VER2%%/VTKTargets-release.cmake in pkg-plist
> should be replaced with lib/cmake/vtk-%%VER2%%/VTKTargets-%%CMAKE_BUILD_T=
YPE%%.cmake
> or mark the port broken for WITH_DEBUG :)

Fixed in r348542, thanks!

>=20
> Max

--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--hOcCNbCCxyk/YU74
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQJ8BAEBCgBmBQJTKEmrXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB
REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgieOl8P/3UTG4Tn9pOxxjo9AQAgyw3X
PcUnJQmuARwnxZhTvMmNg81V3AZQ4gRX2jcEi9Ho9Qe1JgkZL5NORSqivILjjrXW
SKXbdaK6kisUVvcccYjn2q9Xlyg+naKowo3yQTkv918eBHfF96Aon4rh7QKJefZN
LMW5SPg/q36xW0cs+iQ3iR0+IJc1VJOYvNgrww3eGySHG62oUEKmvAZ6woHyhtHl
5Nv8cZsoqZuVQzJ/zU4gbwFsaVw8ETK9zUzk8+jxFvZMgLZS2urrMpO+haiLBjuK
nh3G9byBh6nxZi7+h02qMN1hZT2H+iWJUf44AID1VG2Jhvuhr707hIKzyMglEHkn
rweI8fLMXXlLVdz/YgUG4iZpbTJn9UPyuu0ijE+/ognkEFeOnLVDR3Qz9ZiWC0bq
KwIfwzzyrlT2yWzWI5VH3GBIO0dDlD2IzSL7tVYcrtOdyMLMgHolhTdMW0cyTx2U
HgsClDS2upV+atC47J/mVvw/eVaVpo+TBLe78uCjFqGQL+8++LeMi8MiH0e3sQ2B
uQ+NWCa10mz1MgsH7vjsG3v2Zl9xp5Z/ZQ11xCc4y4XAcT14TvSxIuYIFCWJMIIy
Apkm6hSAj1lcvHAavVWh1nMai2CzTDb0NgG5DxGRpHtyhtFZbLoojvktjUhxpn2a
yH5m/F1pxsEjXzXoW3Ej
=WRL5
-----END PGP SIGNATURE-----

--hOcCNbCCxyk/YU74--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140318132711.GC64859>