From owner-cvs-all Thu Aug 2 6:27: 3 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id DFC9F37B401; Thu, 2 Aug 2001 06:26:55 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.4/8.11.4) with SMTP id f72DOEf71281; Thu, 2 Aug 2001 09:24:14 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 2 Aug 2001 09:24:14 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c menus.c sysinstall.h In-Reply-To: <20010802160319.A97554@nagual.pp.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 2 Aug 2001, Andrey A. Chernov wrote: > On Wed, Aug 01, 2001 at 20:53:36 -0700, Robert Watson wrote: > > rwatson 2001/08/01 20:53:36 PDT > > > > Modified files: > > usr.sbin/sysinstall config.c menus.c sysinstall.h > > Log: > > Add the ability to modify /etc/ttys before first reboot during the > > system installation process. This allows users installing via serial > > console to enable serial console login during the installation > > process using an un-customized install. The user is not prompted to > > modify /etc/ttys during a normal install, but is offered the > > opportunity during post-install configuration. > > Do you check it co-exixt well with postponed /etc/ttys modifications > (ttys.c etc.)? My reading of ttys.c was that when it is executed, it impacts only the console line of the file, and performs a modification of the file in-place (modulo a temporary file on the way through, as most editors do). If the user has made changes to the console configuration that affect the ttys file, those changes will be applied potentially after the user has edited ttys, it is true. It's not clear to me what the best way to account for this is--perhaps to apply ttys changes immediately during console configuration, or perhaps simply to note in the dialog that pops up before editing /etc/ttys that some changes will be applied later as part of console configuration. That said, there is a name collision (well, not in C, but in my head) between configTTYs and configTtys, and I should probably fix that. Do you have any suggests on how to make these co-exist best? Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message