Date: Wed, 4 Apr 2007 22:03:34 -0700 From: Jeremy Chadwick <koitsu@FreeBSD.org> To: Pav Lucistnik <pav@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Michael Johnson <ahze@ahze.net>, "Robert C. Noland III" <rnoland@2hip.net>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/multimedia/libdvdread Makefile distinfo pkg-plist ports/multimedia/libdvdread/files extra-patch-dvdread::bswap.h patch-dvdread::bswap.h patch-dvdread::dvd_input.c Message-ID: <20070405050334.GA87770@icarus.home.lan> In-Reply-To: <1175722391.91901.12.camel@ikaros.oook.cz> References: <200704041404.l34E4SBI058283@repoman.freebsd.org> <b2203fed0704040946j1f4dbf58i939e46cb3b3e6191@mail.gmail.com> <20070404211821.GA78673@icarus.home.lan> <1175722391.91901.12.camel@ikaros.oook.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 04, 2007 at 11:33:11PM +0200, Pav Lucistnik wrote: > Jeremy Chadwick pí?e v st 04. 04. 2007 v 14:18 -0700: > > On Wed, Apr 04, 2007 at 12:46:02PM -0400, Michael Johnson wrote: > > > you're planning on updating all the ports that depend on this, right? > > > > I've discussed this with my mentor. The answer is yes -- although > > all of the ports dependant on this library need to be tested, > > particularly ones which do not explicitly specify which .so version > > they desire (ex. sysutils/k3b). > > > > I'll begin work on this in a few hours. > > The mechanical update of shmajor version in dependency lines should have > been part of the initial commit. Please fix ASAP. > > Your mentor should have alerted you to this. (Adding libdvdread maintainer to CC) I've finished my initial testing as promised. Initially some ports built fine while others errored out during compile or configure: dvdread/ifo_types.h:32:2: #error "Must include <inttypes.h> or <stdint.h> before any libdvdread header." This comes from the new libdvdread library. The authors of the software #error in their include files if <stdint.h> or <inttypes.h> aren't included. Their #ifdef logic breaks on FreeBSD (and IMHO the logic is flawed). So I made a patch, which will require libdvdread have its PORTREVISION incremented: --- dvdread/ifo_types.h.orig Thu Mar 2 17:25:43 2006 +++ dvdread/ifo_types.h Wed Apr 4 20:07:32 2007 @@ -29,7 +29,11 @@ #endif #else #if !defined(UINT8_MAX) || !defined(UINT16_MAX) || !defined(INT32_MAX) -#error "Must include <inttypes.h> or <stdint.h> before any libdvdread header." +#if !defined(_SYS_STDINT_H_) || !defined(_INTTYPES_H_) +#include <stdint.h> +#else +#error "UINT8_MAX, UINT16_MAX, or INT32_MAX are missing from <stdint.h> or <inttypes.h>." +#endif #endif #endif Ports which build and run successfully now, thus will have their PORTREVISION incremented and the LIB_DEPENDS .so version updated: ports/multimedia/dvdauthor ports/multimedia/libdvdnav ports/multimedia/libdvdplay ports/multimedia/lsdvd (requires libdvdread 0.9.7_2) ports/multimedia/mmpython (requires libdvdread 0.9.7_2) ports/multimedia/ogmtools ports/multimedia/streamanalyze (requires libdvdread 0.9.7_2) ports/multimedia/streamdvd (requires libdvdread 0.9.7_2) ports/multimedia/vamps ports/net/vls (requires libdvdread 0.9.7_2) ports/sysutils/dvdbackup (requires libdvdread 0.9.7_2) ports/sysutils/vobcopy ports/sysutils/vstrip All of the above will be committed once my mentor reviews it. :-) However, the following ports I couldn't test because I lack X/QT/KDE: ports/multimedia/handbrake ports/multimedia/handbrake-gtk2 ports/multimedia/k9copy ports/multimedia/ldvd ports/multimedia/libxine ports/multimedia/mplayerxp ports/multimedia/ogle ports/multimedia/ogmrip ports/multimedia/qvamps ports/multimedia/transcode ports/multimedia/vlc ports/multimedia/vlc-devel ports/sysutils/k3b -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. PGP: 4BD6C0CB |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070405050334.GA87770>