From owner-cvs-all@FreeBSD.ORG  Fri Aug  1 10:13:50 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 14239106564A
	for <cvs-all@freebsd.org>; Fri,  1 Aug 2008 10:13:50 +0000 (UTC)
	(envelope-from keramida@ceid.upatras.gr)
Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36])
	by mx1.freebsd.org (Postfix) with ESMTP id 828068FC18
	for <cvs-all@freebsd.org>; Fri,  1 Aug 2008 10:13:49 +0000 (UTC)
	(envelope-from keramida@ceid.upatras.gr)
Received: from kobe.laptop (adsl151-101.kln.forthnet.gr [62.1.242.101])
	(authenticated bits=128)
	by igloo.linux.gr (8.14.3/8.14.3/Debian-5) with ESMTP id m71ADFWs012035
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Fri, 1 Aug 2008 13:13:21 +0300
Received: from kobe.laptop (kobe.laptop [127.0.0.1])
	by kobe.laptop (8.14.2/8.14.2) with ESMTP id m71ADF71031809;
	Fri, 1 Aug 2008 13:13:15 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
Received: (from keramida@localhost)
	by kobe.laptop (8.14.2/8.14.2/Submit) id m71ADFE8031808;
	Fri, 1 Aug 2008 13:13:15 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Doug Barton <dougb@freebsd.org>
References: <200807161029.m6GATt4V031164@repoman.freebsd.org>
	<87ej59kqmr.fsf@kobe.laptop>
Date: Fri, 01 Aug 2008 13:13:15 +0300
In-Reply-To: <87ej59kqmr.fsf@kobe.laptop> (Giorgos Keramidas's message of
	"Fri, 01 Aug 2008 12:53:48 +0300")
Message-ID: <877ib1kpqc.fsf@kobe.laptop>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-MailScanner-ID: m71ADFWs012035
X-Hellug-MailScanner: Found to be clean
X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,
	score=-4.003, required 5, autolearn=not spam, ALL_TRUSTED -1.80,
	AWL 0.40, BAYES_00 -2.60)
X-Hellug-MailScanner-From: keramida@ceid.upatras.gr
X-Spam-Status: No
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/conf newvers.sh
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Aug 2008 10:13:50 -0000

On Fri, 01 Aug 2008 12:53:48 +0300, Giorgos Keramidas <keramida@freebsd.org> wrote:
> On Wed, 16 Jul 2008 10:29:42 +0000 (UTC), Doug Barton <dougb@freebsd.org> wrote:
>> dougb       2008-07-16 10:29:42 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:        (Branch: RELENG_6)
>>     sys/conf             newvers.sh
>>   Log:
>>   SVN rev 180557 on 2008-07-16 10:29:42Z by dougb
>>
>>   MFC r179637, r179655, and r180503, the inclusion of the svnversion info
>>   for uname.
>>
>>   Revision   Changes    Path
>>   1.69.2.17  +18 -2     src/sys/conf/newvers.sh
>
> Hi Doug,
>
> Instead of trying to guess ${SRCDIR} we could let make tell us its
> value, at the last possible moment, by a patch like the one below.
> Does it look like something we should commit?
>
> %%%
> diff -r fe80b79b9f0e sys/conf/kern.post.mk
> --- a/sys/conf/kern.post.mk	Fri Aug 01 02:48:36 2008 +0000
> +++ b/sys/conf/kern.post.mk	Fri Aug 01 12:50:18 2008 +0300
> @@ -244,7 +244,7 @@
>  	${NORMAL_LINT}
>
>  vers.c: $S/conf/newvers.sh $S/sys/param.h ${SYSTEM_DEP}
> -	MAKE=${MAKE} sh $S/conf/newvers.sh ${KERN_IDENT}
> +	MAKE=${MAKE} SRCDIR=$s sh $S/conf/newvers.sh ${KERN_IDENT}

``SRCDIR=$S'' of course...  Sorry for botching the copy/paste here.