From owner-cvs-all Sat Jun 15 17: 5: 8 2002 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 1E76637B8BB; Sat, 15 Jun 2002 17:04:40 -0700 (PDT) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 357D1816EA; Sun, 16 Jun 2002 09:34:18 +0930 (CST) Date: Sun, 16 Jun 2002 09:34:18 +0930 From: Greg 'groggy' Lehey To: Pete Fritchman Cc: Alexey Zelkin , Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/calendar Makefile Message-ID: <20020616000418.GE65995@wantadilla.lemis.com> References: <200206132122.g5DLM0x90794@freefall.freebsd.org> <20020614191040.H2820-100000@gamplex.bde.org> <200206132122.g5DLM0x90794@freefall.freebsd.org> <20020614121629.A26139@ark.cris.net> <20020614191040.H2820-100000@gamplex.bde.org> <20020615231946.GA65995@wantadilla.lemis.com> <20020615195035.A79216@absolutbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020615195035.A79216@absolutbsd.org> User-Agent: Mutt/1.3.99i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Saturday, 15 June 2002 at 19:50:35 -0400, Pete Fritchman wrote: > ++ 16/06/02 08:49 +0930 - Greg 'groggy' Lehey: >>> It is a style bug at best to create destination directories directly, >>> especially using mkdir -p instead of install -d to ensure having little >>> control over the directories' attributes. >> >> I tried install -d first, and got problems which suggested that I was >> misunderstanding its use. Here's the rule I had: >> >> .for lang in ${INTER} >> ${INSTALL} -d -c -o ${BINOWN} -g ${BINGRP} -m ${TEXTMODE} \ >> ${.CURDIR}/calendars/${lang}/calendar.* \ >> ${DESTDIR}${SHAREDIR}/calendar/${lang} >> .endfor > > install -d just creates the directory, it doesn't put files there too. > > entropy(~) [121] > install -d foo > entropy(~) [122] > ls -ld foo > drwxr-xr-x 2 petef wheel 512 Jun 15 19:50 foo/ > entropy(~) [123] > Ah, thanks. So what about this? .for lang in ${INTER} install -d -o ${BINOWN} -g ${BINGRP} -m ${DIRMODE} ${DESTDIR}${SHAREDIR}/calendar/${lang} ${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m ${TEXTMODE} \ ${.CURDIR}/calendars/${lang}/calendar.* \ ${DESTDIR}${SHAREDIR}/calendar/${lang} .endfor I know that this doesn't address the question about whether this should be done by mtree or not. Normally it would, but I don't believe that the 'make install' should fail because it's done in the directory. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message