From owner-freebsd-ipfw@FreeBSD.ORG  Mon Feb 23 09:07:35 2004
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 94A6216A4CE
	for <freebsd-ipfw@freebsd.org>; Mon, 23 Feb 2004 09:07:35 -0800 (PST)
Received: from moutng.kundenserver.de (moutng.kundenserver.de
	[212.227.126.171])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 57AC343D1F
	for <freebsd-ipfw@freebsd.org>; Mon, 23 Feb 2004 09:07:35 -0800 (PST)
	(envelope-from max@love2party.net)
Received: from [212.227.126.205] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1AvJYM-0002p7-00
	for freebsd-ipfw@freebsd.org; Mon, 23 Feb 2004 18:07:34 +0100
Received: from [80.131.154.186] (helo=vampire.homelinux.org)
	by mrelayng.kundenserver.de with asmtp (Exim 3.35 #1)
	id 1AvJYL-0002YE-00
	for freebsd-ipfw@freebsd.org; Mon, 23 Feb 2004 18:07:33 +0100
Received: (qmail 32912 invoked from network); 23 Feb 2004 17:11:49 -0000
Received: from unknown (HELO fbsd52.laiers.local) (192.168.4.88)
  by 192.168.4.1 with SMTP; 23 Feb 2004 17:11:49 -0000
From: Max Laier <max@love2party.net>
To: Alexander Motin <mav@alkar.net>, freebsd-net@freebsd.org,
	freebsd-ipfw@freebsd.org
Date: Mon, 23 Feb 2004 18:07:29 +0100
User-Agent: KMail/1.5.4
References: <c0soic$1njq$2@pandora.alkar.net.lucky.freebsd.net>
	<c1d9id$10qf$1@pandora.alkar.net>
In-Reply-To: <c1d9id$10qf$1@pandora.alkar.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200402231807.29317.max@love2party.net>
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:e28873fbe4dbe612ce62ab869898ff08
Subject: Re: Generating 'Fragment Needed but DF was Set' ICMP & Dummynet
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 17:07:35 -0000

On Monday 23 February 2004 17:25, Alexander Motin wrote:
> Here are my patches for this problem for FreeBSD 4.8 and 5.2.
> Review them please.

Looks good, though you might want to make sure to update statistics=20
(ipstat.ips_cantfrag++). And maybe lose the type and code vars - you=20
don't really use them:
=2D=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0typ=
e =3D ICMP_UNREACH;
=2D=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0 =A0 =A0 =A0code =3D IC=
MP_UNREACH_HOST;
=2D=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0icm=
p_error(mcopy, type, code, 0, pkt->ifp);
+			icmp_error(mcopy, ICMP_UNREACH, ICMP_UNREACH_HOST,
+			    0, pkt->ifp);

Also note that this patch will require some work after the MT_TAG remove=20
http://people.freebsd.org/~mlaier/mt_tag_remove.diff as pkt is freed with=20
the mbuf. I'll keep it in mind.

=2D-=20
Best regards,				| mlaier@freebsd.org
Max Laier				| ICQ #67774661
http://pf4freebsd.love2party.net/	| mlaier@EFnet