Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Oct 2018 06:23:59 +0000 (UTC)
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r482271 - in head/lang: python27 python35 python36 python37
Message-ID:  <201810170623.w9H6Nxf2029974@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: koobs
Date: Wed Oct 17 06:23:59 2018
New Revision: 482271
URL: https://svnweb.freebsd.org/changeset/ports/482271

Log:
  lang/python27,35+: Remove MAKE_JOBS_UNSAFE
  
  ports r393217 via bug 200622 [1] originally set MAKE_JOBS_UNSAFE=yes due to
  incorrect uses of recursive make [2], causing intermittent build failures when
  run with multiple jobs (-jN).
  
  Upstream committed a fix for the issue in default (3.6, at the time), 3.5 and
  2.7 which are now contained in all released lang/python?? port versions. 3.4 did
  not receieve a backport merge.
  
  lang/python3.5+ ports inadvertently inherited MAKE_JOBS_UNSAFE=yes, via
  repocopies from lang/python34 on their creation, when they were infact safe to
  use with -j.
  
  Remove MAKE_JOBS_UNSAFE in all lang/python?? ports except python34 accordingly.
  
  [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200622
  [2] https://bugs.python.org/issue22359
  
  PR:		232308
  Reported by:	cem
  Reviewed by:	cem
  Approved by:	koobs (python)
  MFH:		2018Q4
  Differential Revision:	D17579

Modified:
  head/lang/python27/Makefile
  head/lang/python35/Makefile
  head/lang/python36/Makefile
  head/lang/python37/Makefile

Modified: head/lang/python27/Makefile
==============================================================================
--- head/lang/python27/Makefile	Wed Oct 17 06:22:29 2018	(r482270)
+++ head/lang/python27/Makefile	Wed Oct 17 06:23:59 2018	(r482271)
@@ -34,7 +34,6 @@ TEST_TARGET=		buildbottest
 TEST_ARGS=		TESTOPTS=-j${MAKE_JOBS_NUMBER}
 
 MAKE_ARGS+=		INSTALL_SHARED="${INSTALL_LIB}"				# Strip shared library
-MAKE_JOBS_UNSAFE=	yes							# Parser/pgen build bug. See Issue: 200622, 201974
 
 PLIST_SUB=		ABI=${ABIFLAGS} \
 			PORTVERSION=${PORTVERSION} \

Modified: head/lang/python35/Makefile
==============================================================================
--- head/lang/python35/Makefile	Wed Oct 17 06:22:29 2018	(r482270)
+++ head/lang/python35/Makefile	Wed Oct 17 06:23:59 2018	(r482271)
@@ -37,7 +37,6 @@ TEST_TARGET=		buildbottest
 TEST_ARGS=		TESTOPTS=-j${MAKE_JOBS_NUMBER}
 
 MAKE_ARGS+=		INSTALL_SHARED="${INSTALL_LIB}"				# Strip shared library
-MAKE_JOBS_UNSAFE=	yes							# Parser/pgen build bug. See Issue: 200622, 201974
 
 SUB_FILES=		pkg-message
 SUB_LIST=		PYTHON_SUFFIX=${PYTHON_SUFFIX}

Modified: head/lang/python36/Makefile
==============================================================================
--- head/lang/python36/Makefile	Wed Oct 17 06:22:29 2018	(r482270)
+++ head/lang/python36/Makefile	Wed Oct 17 06:23:59 2018	(r482271)
@@ -37,7 +37,6 @@ TEST_TARGET=		buildbottest
 TEST_ARGS=		TESTOPTS=-j${MAKE_JOBS_NUMBER}
 
 MAKE_ARGS+=		INSTALL_SHARED="${INSTALL_LIB}"				# Strip shared library
-MAKE_JOBS_UNSAFE=	yes							# Parser/pgen build bug. See Issue: 200622, 201974
 
 SUB_FILES=		pkg-message
 SUB_LIST=		PYTHON_SUFFIX=${PYTHON_SUFFIX}

Modified: head/lang/python37/Makefile
==============================================================================
--- head/lang/python37/Makefile	Wed Oct 17 06:22:29 2018	(r482270)
+++ head/lang/python37/Makefile	Wed Oct 17 06:23:59 2018	(r482271)
@@ -37,7 +37,6 @@ TEST_TARGET=		buildbottest
 TEST_ARGS=		TESTOPTS=-j${MAKE_JOBS_NUMBER}
 
 MAKE_ARGS+=		INSTALL_SHARED="${INSTALL_LIB}"				# Strip shared library
-MAKE_JOBS_UNSAFE=	yes							# Parser/pgen build bug. See Issue: 200622, 201974
 
 SUB_FILES=		pkg-message
 SUB_LIST=		PYTHON_SUFFIX=${PYTHON_SUFFIX}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201810170623.w9H6Nxf2029974>