Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 31 May 2013 21:45:09 +0200
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        jpaetzel@freebsd.org
Subject:   ports/179156: [PATCH] net/tcptrace: Add license, trim docs, fix pkg-descr, comply with OptionsNG
Message-ID:  <20130531194512.8A21AF69@hub.freebsd.org>
Resent-Message-ID: <201305311950.r4VJo2MN031099@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179156
>Category:       ports
>Synopsis:       [PATCH] net/tcptrace: Add license, trim docs, fix pkg-descr, comply with OptionsNG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 31 19:50:02 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29 18:27:25 UTC 2013
>Description:

- Shorten header
- Trim comment
- Add license
- Comply with OptionsNG
- Trim docs
- Fix pkg-descr
- Remove pkg-plist
- Make portlint happy
- Cleanup port

Removed file(s):
- pkg-plist

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130531184401-40307/

>Fix:

--- tcptrace-6.6.7.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/net/tcptrace/Makefile ./Makefile
--- /usr/ports/net/tcptrace/Makefile	2013-01-14 17:56:33.000000000 +0100
+++ ./Makefile	2013-05-31 20:43:01.000000000 +0200
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	tcptrace
-# Date created:		3 March 1997
-# Whom:			fenner
-#
+# Created by: fenner
 # $FreeBSD: head/net/tcptrace/Makefile 300897 2012-07-14 14:29:18Z beat $
-#
 
 PORTNAME=	tcptrace
 PORTVERSION=	6.6.7
@@ -11,31 +7,35 @@
 MASTER_SITES=	http://www.tcptrace.org/download/
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A TCP dump file analysis tool
+COMMENT=	TCP dump file analysis tool
 
-MAKE_JOBS_SAFE=  yes
+LICENSE=	GPLv2
 
 GNU_CONFIGURE=	yes
 ALL_TARGET=	tcptrace
+MAKE_JOBS_SAFE=	yes
+
+PLIST_FILES=	bin/${PORTNAME} \
+		bin/xpl2gpl
 
 MAN1=		tcptrace.1
 
-DOCFILES=	ARGS CHANGES COPYING COPYRIGHT FAQ README README.mailing_list \
+PORTDOCS=	ARGS CHANGES FAQ README README.mailing_list \
 		README.modules README.tline_graphs README.tput_graphs \
-		README.version README.xpl2gpl THANKS WWW \
-		dot_tcptracerc
+		README.version README.xpl2gpl THANKS dot_tcptracerc
+
+.include <bsd.port.options.mk>
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/tcptrace ${PREFIX}/bin
 	${INSTALL_SCRIPT} ${WRKSRC}/xpl2gpl ${PREFIX}/bin
-	${INSTALL_MAN} ${WRKSRC}/tcptrace.man ${PREFIX}/man/man1/tcptrace.1
 
 post-install:
-.if !defined(NOPORTDOCS)
-	${MKDIR} ${DOCSDIR}
-.for file in ${DOCFILES}
-	${INSTALL_MAN} ${WRKSRC}/${file} ${DOCSDIR}
-.endfor
+	${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.man ${MAN1PREFIX}/man/man1/${PORTNAME}.1
+
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
diff -ruN --exclude=CVS /usr/ports/net/tcptrace/pkg-descr ./pkg-descr
--- /usr/ports/net/tcptrace/pkg-descr	2013-01-14 17:56:33.000000000 +0100
+++ ./pkg-descr	2013-03-31 18:51:10.000000000 +0200
@@ -1,28 +1,15 @@
-tcptrace a TCP dump file analysis tool written by Shawn Ostermann
-at Ohio University. It is NOT a packet capture program. It reads
-output dump files in the formats of several popular packet capturing
-programs: tcpdump, snoop, etherpeek, and netm.  It can also output
-(ie, convert thus converting to) tcpdump format files.
+tcptrace is a TCP connection analysis tool. It can tell you detailed
+information about TCP connections by sifting through dump files.
+The dump file formats supported are:
+   Standard tcpdump format (you need the pcap library)
+   Sun's snoop format
+   Macintosh Etherpeek format
+   HP/NetMetrix protocol analysis format
+   NS simulator output format
+   NetScout
+   NLANR Tsh Format
 
-For each connection, it keeps track of elapsed time, bytes/segments
-sent and received, retransmissions, round trip times, window
-advertisements, throughput, etc.  Its output format ranges from
-Simple to Long to Very Detailed.
-
-It can also produce three different types of graphs, as follows: 
-
-   Time Sequence Graph 
-     This is the format that Tim Shepard started using at MIT some
-     years ago. It shows segments sent and ACKs returned as a
-     function of time.
-   Instantaneous Throughput 
-     This format shows the instantaneous (averaged over a few
-     segments) throughput of the connection as a function of time.
-   Round Trip Times 
-     This format shows the round trip times for the ACKs as a
-     function of time.
-
-The graphs produced are viewable only by Tim Shepard's wonderful
-xplot program (in math/xplot).
+To see the graphs, you'll also need Tim Shepard's xplot program,
+available at http://www.xplot.org
 
 WWW: http://www.tcptrace.org/
diff -ruN --exclude=CVS /usr/ports/net/tcptrace/pkg-plist ./pkg-plist
--- /usr/ports/net/tcptrace/pkg-plist	2013-01-14 17:56:33.000000000 +0100
+++ ./pkg-plist	1970-01-01 01:00:00.000000000 +0100
@@ -1,18 +0,0 @@
-bin/tcptrace
-bin/xpl2gpl
-%%PORTDOCS%%%%DOCSDIR%%/ARGS
-%%PORTDOCS%%%%DOCSDIR%%/CHANGES
-%%PORTDOCS%%%%DOCSDIR%%/COPYING
-%%PORTDOCS%%%%DOCSDIR%%/COPYRIGHT
-%%PORTDOCS%%%%DOCSDIR%%/FAQ
-%%PORTDOCS%%%%DOCSDIR%%/README
-%%PORTDOCS%%%%DOCSDIR%%/README.mailing_list
-%%PORTDOCS%%%%DOCSDIR%%/README.modules
-%%PORTDOCS%%%%DOCSDIR%%/README.tline_graphs
-%%PORTDOCS%%%%DOCSDIR%%/README.tput_graphs
-%%PORTDOCS%%%%DOCSDIR%%/README.version
-%%PORTDOCS%%%%DOCSDIR%%/README.xpl2gpl
-%%PORTDOCS%%%%DOCSDIR%%/THANKS
-%%PORTDOCS%%%%DOCSDIR%%/WWW
-%%PORTDOCS%%%%DOCSDIR%%/dot_tcptracerc
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
--- tcptrace-6.6.7.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130531194512.8A21AF69>