From owner-cvs-src@FreeBSD.ORG Wed Jan 2 21:15:04 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C05A16A469; Wed, 2 Jan 2008 21:15:04 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id E2E7913C43E; Wed, 2 Jan 2008 21:15:03 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 95C9217107; Wed, 2 Jan 2008 21:15:02 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.2/8.14.2) with ESMTP id m02LF18T001430; Wed, 2 Jan 2008 21:15:02 GMT (envelope-from phk@critter.freebsd.dk) To: Nate Lawson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 02 Jan 2008 13:01:17 PST." <477BFB9D.8070201@root.org> Date: Wed, 02 Jan 2008 21:15:01 +0000 Message-ID: <1429.1199308501@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2008 21:15:04 -0000 In message <477BFB9D.8070201@root.org>, Nate Lawson writes: >Poul-Henning Kamp wrote: >Ok, but this still doesn't address the performance loss fixed by this >3-year-old patch: I think your patch is wrong because it moves the responsibility for the performance in the wrong direction: We shouldn't have to care about this in every single device driver. When I created bus_{read|write}_* that was mostly to reduce the risk of repetive strain injuries for device driver writers, but it was also an attempt to move the responsibility in the right direction. rman and bus_space was sort of conceived separately, but it is time they realize that they are indeed a couple so everybody don't have to pretend how surprised they are to see them together at this instant. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.