From owner-svn-src-head@freebsd.org Sat Aug 11 22:25:03 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6CB4107B814 for ; Sat, 11 Aug 2018 22:25:03 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic316-14.consmr.mail.bf2.yahoo.com (sonic316-14.consmr.mail.bf2.yahoo.com [74.6.130.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 43C5593B77 for ; Sat, 11 Aug 2018 22:25:03 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1534026297; bh=Q5P4YW6L0Y4P0GLcto4+N0Ow/QCgnHlMHxEuEyePzoQ=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=PyPNFNUCRIJ0u2kVJn244SD0RUoJ/47ATg+N+9dNaa8LoEbx7totsbiEvOe5ozjyleSWXECfQo9kvX+gfScD/0iO4CFXaJ/fZeXMvEC2bMEB/960EEbP0lgmctPbb4GUIFOUg2fNSGS/PFKjSjjWB/nl7Fj+QZcAOde6zXt0umSbhXjHbNKsuyOv5wDcNzkAIoLOV1G0EPfzqPgHNkNpxXtYaTIgrAeEV0Jdaum869uo/XdbLSteVmMPVwc4DRnfkmX3ee+x7//+knphddr5hBeKrOiz3Gv7gQsmBDj3ed3U703doA6Cxdj3oq85fnXs6DWhJ8wJQNNIW4VgyHZn4A== X-YMail-OSG: .Aewo0IVM1lB4flzbuStYJXkEyOLn2KNf5flleksN9Vx_USOSPZC7ujyn7uhAaB GlBEPiRqoRU0obOkXPT2lgwukfdBh0cBUJpYQiHlnHOxUkzB.hLdyh7lLyuGy9h3AnzHcuJglx3P ypiCO8LkRn.XnUr7l5xyi4sLCcpPlbqCgoiyecPX3oFp4HXMCfd9VMR9D81TaYF.dzke46eQvT1d QQg7jleAE_1LQuOwZdKTDZ8ek1g7a.eBmjj6TTNo7KkgD1LBFgwYyDonEwR5REjgAX8wWX.gATbG droZ3rL2xHjPKos1AswTAE8VJpprD3D9bxQmU1RdP42FqgoBeJy6o46WE5qr6yJdAS932xHwlAFU kHELL_ZCgCsJACTyQgDIpienur3YckUwrFz6leDnrsBUW_Cc1Li0dC8tNF9rWOF8rnGsJrawo95q dD_iyxPPunOUOKNhIBOWQhQWWn0LH1d7ZSTXzXxG6MGxdnRSBlomrwdkzDTo6vGCo31e1I_eIkY1 YvW0L2GdUesnMw2xtFVVcU3eBzQBOjBBDReWbu2Y.65Ww_q.ZV319_VR0khaOPuPzzhpnzCAB3wH FIASqjeeKHnGmjN.9wp9H_0.E6lbo9PEaxJNrIQO5Vv1VyIFoj3fzq6X4vXtoGGxhMWFdL6ZReME gDCSHpCJMKMjIcox0vVNbwi48QJH82Auf8rC7Q3emvWqozR01HhxUT30wNw1o6oZd00I5KyTGgYp 6CjNIHoRdFKdHtCsAyGbgbmrXIxjEK9GPWyxhSyXomfwIVhjnWdqyGTPHe_i7DVmWOdyuFmZY1Y3 aBJWvhPeFa9xbOY9MULY9EJBYoP.ponv5WCbQ5ENuGAKlbhjz7hzZBrVcz6a8Zj5NPeEym0mL24i Ryj7FGJzUCNCpX_q50y1GyNWj8EyplifRyoy4TbdacmFrRZ6XfGkakxxea.vYoEG_AMjkMktfeQ2 TaQBSuBOABGnplqQzUOmUpAsXcpg8opHI0ir5WBy44uTtM.DTleUW8.L6 Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.bf2.yahoo.com with HTTP; Sat, 11 Aug 2018 22:24:57 +0000 Received: from 181.52.72.201 (EHLO [192.168.0.2]) ([181.52.72.201]) by smtp408.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID b33bb553079d60f29c2954792639d9a5; Sat, 11 Aug 2018 22:24:56 +0000 (UTC) Subject: Re: svn commit: r337618 - head/usr.bin/printf To: Jilles Tjoelker , svn-src-head@freebsd.org References: <201808111113.w7BBDYTM053399@repo.freebsd.org> From: Pedro Giffuni Message-ID: Date: Sat, 11 Aug 2018 17:24:57 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201808111113.w7BBDYTM053399@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Aug 2018 22:25:03 -0000 Duh! On 08/11/18 06:13, Jilles Tjoelker wrote: > Author: jilles > Date: Sat Aug 11 11:13:34 2018 > New Revision: 337618 > URL: https://svnweb.freebsd.org/changeset/base/337618 > > Log: > printf: Fix \c in %b in printf builtin exiting the shell after r337458 > > SVN r337458 erroneously partially reverted r265885. > > This is immediately visible when running the Kyua/ATF tests for > usr.bin/printf, which actually test sh's printf builtin. > > PR: 229641 > > Modified: > head/usr.bin/printf/printf.c > > Modified: head/usr.bin/printf/printf.c > ============================================================================== > --- head/usr.bin/printf/printf.c Sat Aug 11 11:05:22 2018 (r337617) > +++ head/usr.bin/printf/printf.c Sat Aug 11 11:13:34 2018 (r337618) > @@ -388,7 +388,7 @@ printf_doformat(char *fmt, int *rval) > > free(p); > if (getout) > - exit(*rval); > + return (end_fmt); > break; > } > case 'c': { > Thanks for fixing this! I recall it's the second time I (inadvertently) commit this bug. So great to have a corresponding test! Pedro.