From owner-freebsd-current@FreeBSD.ORG Sun Apr 28 02:04:02 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 2DF2298D for ; Sun, 28 Apr 2013 02:04:02 +0000 (UTC) (envelope-from sendtomatt@gmail.com) Received: from mail-da0-x22f.google.com (mail-da0-x22f.google.com [IPv6:2607:f8b0:400e:c00::22f]) by mx1.freebsd.org (Postfix) with ESMTP id 084BE1310 for ; Sun, 28 Apr 2013 02:04:02 +0000 (UTC) Received: by mail-da0-f47.google.com with SMTP id p1so2439025dad.6 for ; Sat, 27 Apr 2013 19:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=FhtTy+mXiNl7vP6vXJamb7smTzQJfacbBQE2AWObAKQ=; b=bibwOEb3ZyiBxZO2k5ZkAaziu67ea40c/DYOP5r3CssPnxhOcwKN/OXScWg9EnSh8V J/lM0Rr5P+AtFaJ37Hsl79R3Y2AfvtCsyijwJwMIy2xy3tACUnsqCbQQByVrqvIL2PJQ jl8Pu5waZoqi6mz/wrCu51LsvChYsoL5+Xaz8NhzlHy005Y2k8Mdcb7m0wPbLDrG6Mgs sDO+6fa4FgOba7zz1nE1JlTFnFDtxw3R24Rc5Rt9yfg0Beq1DE37pHSWufwMcEODgvwK 5O5wDlkw+S0SaiwbHR0EeUBxVuSIX4/FdxTDTpBfNSCKNEDd868te7onJoe9DI3QjwjL CR0w== X-Received: by 10.66.81.2 with SMTP id v2mr40628482pax.204.1367114641818; Sat, 27 Apr 2013 19:04:01 -0700 (PDT) Received: from flatline.local (70-36-223-239.dsl.dynamic.sonic.net. [70.36.223.239]) by mx.google.com with ESMTPSA id dr4sm17894175pbb.19.2013.04.27.19.04.00 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 27 Apr 2013 19:04:01 -0700 (PDT) Message-ID: <517C8382.8090404@gmail.com> Date: Sat, 27 Apr 2013 19:03:46 -0700 From: matt User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130405 Thunderbird/17.0.5 MIME-Version: 1.0 To: Steven Hartland Subject: Re: r249939+ not detecting ata trim References: <517C3C87.1020005@gmail.com> <37582339ED1A4356B6DE6142B2FBCD7B@multiplay.co.uk> <517C7969.4090501@gmail.com> <517C7E4B.1030501@gmail.com> <33B1A5523E9949278464E92CC6BB722E@multiplay.co.uk> In-Reply-To: <33B1A5523E9949278464E92CC6BB722E@multiplay.co.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Apr 2013 02:04:02 -0000 On 04/27/13 18:51, Steven Hartland wrote: > ----- Original Message ----- From: "matt" >>> FYI: Change only requires kernel, world would be identical, which >>> should save you some time. >> >> And some untrimmed deletes! >> >> Thanks, with geom/cam/disk stuff I usually assume that it could affect >> userland out of caution. >> >> BTW...ata identify is working fine, as even before the patch camcontrol >> identify indicated trim support. > > Could you confirm the output you got from the debug as I would have > expected to see UNMAP supported on your machine if you mps? Output for sysctls kern.cam.da.3.delete_method: ATA_TRIM kern.cam.da.3.delete_max: 17179607040 kern.cam.da.3.minimum_cmd_size: 6 kern.cam.da.3.sort_io_queue: 0 kern.cam.da.3.error_inject: 0 kern.cam.da.4.delete_method: ATA_TRIM kern.cam.da.4.delete_max: 17179607040 Output for printf deleteflag: ATA_TRIM (2) = 1 I thought UNMAP was a SCSI command (for SAS disks), unless we're calling it UNMAP and then running ATA's TRIM? > I can envisage people wanting to know what delete methods are detected > as supported so I've created a new little patch which will print this > out from a verbose boot. > > Its attached if you want to try it, again only a kernel change, I'd > be interested in the output you get. You should see something like:- > da0: Delete methods: I'll give it a try and send the results. Thanks, Matt