Date: Fri, 30 Aug 2013 17:21:11 +0200 From: =?utf-8?Q?Hans_Petter_Selasky?= <hans.petter.selasky@bitfrost.no> To: =?utf-8?Q?Ian_Lepore?= <ian@FreeBSD.org>, =?utf-8?Q?Andriy_Gapon?= <avg@FreeBSD.org> Cc: =?utf-8?Q?svn-src-head=40FreeBSD=2Eorg?= <svn-src-head@FreeBSD.org>, =?utf-8?Q?svn-src-all=40FreeBSD=2Eorg?= <svn-src-all@FreeBSD.org>, =?utf-8?Q?src-committers=40FreeBSD=2Eorg?= <src-committers@FreeBSD.org> Subject: RE: svn commit: r255067 - head/sys/kern Message-ID: <zarafa.5220b867.1b06.74dac1171078facd@mail.lockless.no> In-Reply-To: <1377874374.1111.328.camel@revolution.hippie.lan> References: <201308301039.r7UAduI1052038@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ian,=0D=0A=0D=0AJust do a:=0D=0A=0D=0Agrep -r DELAY sys=0D=0A=0D=0AMos= tly when kernel is in panic mode and at the end of shutdown.=0D=0A=0D=0A-= -HPS=20=0D=0A=20=0D=0A-----Original message-----=0D=0A> From:Ian Lepore <= ian@FreeBSD.org <mailto:ian@FreeBSD.org> >=0D=0A> Sent: Friday 30th Augus= t 2013 16:53=0D=0A> To: Andriy Gapon <avg@FreeBSD.org <mailto:avg@FreeBSD= =2Eorg> >=0D=0A> Cc: Hans Petter Selasky <hans.petter.selasky@bitfrost.no= <mailto:hans.petter.selasky@bitfrost.no> >; src-committers@FreeBSD.org <= mailto:src-committers@FreeBSD.org> ; svn-src-all@FreeBSD.org <mailto:svn-= src-all@FreeBSD.org> ; svn-src-head@FreeBSD.org <mailto:svn-src-head@Free= BSD.org>=20=0D=0A> Subject: Re: svn commit: r255067 - head/sys/kern=0D=0A= >=20=0D=0A=0D=0A>=20=0D=0A> What I want to know is why a DELAY() loop nee= ds to function well with=0D=0A> delay values longer than 1 second. Are w= e really doing that=3F=0D=0A>=20=0D=0A> -- Ian=0D=0A>=20=0D=0A>=20=0D=0A>= =20=0D=0A=0D=0A From owner-svn-src-head@FreeBSD.ORG Fri Aug 30 15:26:46 2013 Return-Path: <owner-svn-src-head@FreeBSD.ORG> Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 35811331; Fri, 30 Aug 2013 15:26:46 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 21E142CD3; Fri, 30 Aug 2013 15:26:46 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r7UFQjtk017890; Fri, 30 Aug 2013 15:26:45 GMT (envelope-from marcel@svn.freebsd.org) Received: (from marcel@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r7UFQjkX017889; Fri, 30 Aug 2013 15:26:45 GMT (envelope-from marcel@svn.freebsd.org) Message-Id: <201308301526.r7UFQjkX017889@svn.freebsd.org> From: Marcel Moolenaar <marcel@FreeBSD.org> Date: Fri, 30 Aug 2013 15:26:45 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r255074 - head/sys/dev/uart X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current <svn-src-head.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>; List-Post: <mailto:svn-src-head@freebsd.org> List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 30 Aug 2013 15:26:46 -0000 Author: marcel Date: Fri Aug 30 15:26:45 2013 New Revision: 255074 URL: http://svnweb.freebsd.org/changeset/base/255074 Log: A final test with unmodified code has shown that a delay of 150ms is not giving us a 100% success rate. Bump the delay to 200ms as that seems to do the trick. Note that during testing the delay was added to uart_bus_attach() in uart_core.c. While having the delay in a different place can change the behaviour, it was not expected. Having to bump the delay with another 50ms could therefore be an indication that the problem can not be solved with delays. Reported by: kevlo@ Tested by: kevlo@ Modified: head/sys/dev/uart/uart_dev_ns8250.c Modified: head/sys/dev/uart/uart_dev_ns8250.c ============================================================================== --- head/sys/dev/uart/uart_dev_ns8250.c Fri Aug 30 13:25:15 2013 (r255073) +++ head/sys/dev/uart/uart_dev_ns8250.c Fri Aug 30 15:26:45 2013 (r255074) @@ -465,7 +465,7 @@ ns8250_bus_attach(struct uart_softc *sc) * accidental manner as before. More analysis is warranted, but * at least now we fixed a known regression. */ - DELAY(150); + DELAY(200); return (0); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?zarafa.5220b867.1b06.74dac1171078facd>