From owner-freebsd-embedded@FreeBSD.ORG  Thu Dec 29 16:56:33 2011
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: freebsd-embedded@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 281FE1065670;
	Thu, 29 Dec 2011 16:56:33 +0000 (UTC) (envelope-from stb@lassitu.de)
Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2001:470:1f0b:105e::1ea])
	by mx1.freebsd.org (Postfix) with ESMTP id CA60D8FC13;
	Thu, 29 Dec 2011 16:56:32 +0000 (UTC)
Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id A77531113BD;
	Thu, 29 Dec 2011 16:56:31 +0000 (UTC)
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=iso-8859-1
From: Stefan Bethke <stb@lassitu.de>
In-Reply-To: <E4D24E02-4F0E-43FB-84F0-F5F20925F748@lassitu.de>
Date: Thu, 29 Dec 2011 17:56:31 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <7A8E7854-4696-44B9-B0BE-3D6640BA0A49@lassitu.de>
References: <CAJ-Vmon8+OXQ4g752zZEB-O0BR0sFWO0QUvw--xp2jsBDkx6tQ@mail.gmail.com>
	<0F6CC18F-6973-42A2-AC03-F01BF59458AE@lassitu.de>
	<CAJ-Vmo=Y8pp4iFnw+1hcPae6QXFboz=a7puwgC1kVSZ3JwMgPQ@mail.gmail.com>
	<1100F70E-9DA9-4163-AC9A-423ECE5AA9A3@lassitu.de>
	<CAJ-VmonrnJ7cC6u2LsL9AGusz_+kSwY62Rr1__sg5U_NynJ1SQ@mail.gmail.com>
	<CAJ-Vmo=WSN1oLM=B2HqSHrWyOaOD9BSwwu8=1Wys0CLRJ_N-TA@mail.gmail.com>
	<C637C171-A1A2-4296-84FA-6DE97137DC42@lassitu.de>
	<CAJ-Vmon2boy7OCh_4O0MeCi0yCdZu0OYb5dxHCEK=-+46zBGtg@mail.gmail.com>
	<CAJ-Vmoku5eLEYi5_DXVxK=0=4Ewn2aGepv3YUw4ApuVh_7y2+w@mail.gmail.com>
	<CAJ-VmonvpnaS1rAO+sDRh1E5WfsrZTYE297Kc96prhfKjrM89Q@mail.gmail.com>
	<CAJ-VmokQxQs2DUKL=ONyxnnS7Q28ytmwZJ_thqvc4SvMkmS=cQ@mail.gmail.com>
	<18CABB46-9B9A-41CB-8742-6723C5FF4D67@lassitu.de>
	<C0BF20FD-E30F-4E9C-A0FE-500BE4807B99@bsdimp.com>
	<CAJ-VmokgiQCEG4et3X=3o_MuCMkO9MqkKqa-fjdpEqQNucn=Lw@mail.gmail.com>
	<2CBD8651-E132-49DC-A082-37A8F5C626EA@bsdimp.com>
	<AFE755D6-E462-40B4-A97B-9261303B3A4F@lassitu.de> <CAJ-Vm
	onmMASxJZBAd2doX4eV6s5TF-3kCB0pLSMrWM8r0UsCmg@mail.gmail.com>
	<FC8A0B08-5292-44CC-AEC0-08BF170FCEA4@lassitu.de>
	<267FB3D6-830E-4A2F-8C1C-A96873EDCD31@lassitu.de>
	<EC4D4397-FA60-4CB1-8635-48988215E19A@lassitu.de>
	<CAJ-VmomZeHEyue4eaNGm+w67uDBsOH_2bqocXjBGxyxHXStZ_A@mail.gmail.com>
	<12538AED-175C-4B1E-BF05-6FD05D14CE70@lassitu.de>
	<CAJ-Vmonu_HyhEnS=3aj7X41-LPWcihPA6Wa6jgV3cn7im2N3Kg@mail.gmail.com>
	<2135AD2B-76D4-4B3D-A009-8F3BEC836051@lassitu.de>
	<CAJ-VmomkCLARagMXUmmJ2O8AQsiKwOEvWMLmwUnK=c47yDJvyw@mail.gmail.com>
	<2BB71545-7DE9-493D-92FE-AD4CEDCBF2D1@lassitu.de>
	<E4D24E02-4F0E-43FB-84F0-F5F20925F748@lassitu.de>
To: Adrian Chadd <adrian@freebsd.org>
X-Mailer: Apple Mail (2.1251.1)
Cc: "freebsd-embedded@freebsd.org" <freebsd-embedded@freebsd.org>
Subject: Re: Updated switch/glue patch?
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Dec 2011 16:56:33 -0000

Am 29.12.2011 um 11:18 schrieb Stefan Bethke:

> http://gitorious.org/~stb/freebsd/stb-adrianchadd-freebsd-work (branch =
work/ath)
> http://www.lassitu.de/freebsd/etherswitch-adrian.patch (patch against =
Adrians gitorious repo as of now)
> http://www.lassitu.de/freebsd/etherswitch.tbz (all files)


I've updated the patch:

Improve locking.

There is now one lock for the softc.  SMI bus access is serialized =
through a
softc field protected by sc_mtx.  All bus access functions can be called
with RTL_NOWAIT, making them punt immediately if the bus was already
acquired.  This allows the callout to try and read all three port status
registers, or just abort and wait for the next round.

For bus access through the control device, the functions are called with
RTL_WAITOK, which will make them sleep until the bus becomes available
(through the standard mtx_lock()).

With this version, I get no WITNESS warnings, nor panics from the =
callout.
The retries for I2C select and PHY register access always succeed (100k+
test accesses in a tight loop).


Stefan

--=20
Stefan Bethke <stb@lassitu.de>   Fon +49 151 14070811