Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Jan 2010 15:34:49 +0000 (UTC)
From:      Andrew Gallatin <gallatin@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-6@freebsd.org
Subject:   svn commit: r201511 - stable/6/sys/dev/mxge
Message-ID:  <201001041534.o04FYnQ0001828@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gallatin
Date: Mon Jan  4 15:34:49 2010
New Revision: 201511
URL: http://svn.freebsd.org/changeset/base/201511

Log:
  MFC 200845:
    Don't take the driver mutex in mxge_tick(), as it
    is run with the mutex held.

Modified:
  stable/6/sys/dev/mxge/if_mxge.c
Directory Properties:
  stable/6/sys/   (props changed)
  stable/6/sys/contrib/pf/   (props changed)
  stable/6/sys/dev/cxgb/   (props changed)

Modified: stable/6/sys/dev/mxge/if_mxge.c
==============================================================================
--- stable/6/sys/dev/mxge/if_mxge.c	Mon Jan  4 15:23:32 2010	(r201510)
+++ stable/6/sys/dev/mxge/if_mxge.c	Mon Jan  4 15:34:49 2010	(r201511)
@@ -3638,9 +3638,7 @@ mxge_tick(void *arg)
 	uint16_t cmd;
 
 	ticks = mxge_ticks;
-	mtx_lock(&sc->driver_mtx);
 	running = sc->ifp->if_drv_flags & IFF_DRV_RUNNING;
-	mtx_unlock(&sc->driver_mtx);
 	if (running) {
 		/* aggregate stats from different slices */
 		pkts = mxge_update_stats(sc);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001041534.o04FYnQ0001828>