Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Oct 2006 16:03:40 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 107316 for review
Message-ID:  <200610051603.k95G3eTV026911@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=107316

Change 107316 by rwatson@rwatson_zoo on 2006/10/05 16:03:39

	suser(9) unnecessary in a sysctl write.  Copy and paste bug from
	alq.
	Reviewed by:	sam

Affected files ...

.. //depot/projects/trustedbsd/priv/sys/contrib/dev/ath/freebsd/ah_osdep.c#2 edit

Differences ...

==== //depot/projects/trustedbsd/priv/sys/contrib/dev/ath/freebsd/ah_osdep.c#2 (text+ko) ====

@@ -199,16 +199,13 @@
 	int error;
 
 	if (enable) {
-		error = suser(curthread);
-		if (error == 0) {
-			error = alq_open(&ath_hal_alq, ath_hal_logfile,
-				curthread->td_ucred, ALQ_DEFAULT_CMODE,
-				sizeof (struct athregrec), ath_hal_alq_qsize);
-			ath_hal_alq_lost = 0;
-			ath_hal_alq_emitdev = 1;
-			printf("ath_hal: logging to %s enabled\n",
-				ath_hal_logfile);
-		}
+		error = alq_open(&ath_hal_alq, ath_hal_logfile,
+			curthread->td_ucred, ALQ_DEFAULT_CMODE,
+			sizeof (struct athregrec), ath_hal_alq_qsize);
+		ath_hal_alq_lost = 0;
+		ath_hal_alq_emitdev = 1;
+		printf("ath_hal: logging to %s enabled\n",
+			ath_hal_logfile);
 	} else {
 		if (ath_hal_alq)
 			alq_close(ath_hal_alq);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610051603.k95G3eTV026911>