From owner-freebsd-scsi@FreeBSD.ORG Thu Sep 5 21:09:00 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B95D76B3; Thu, 5 Sep 2013 21:09:00 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ee0-x22b.google.com (mail-ee0-x22b.google.com [IPv6:2a00:1450:4013:c00::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CA41B20B3; Thu, 5 Sep 2013 21:08:59 +0000 (UTC) Received: by mail-ee0-f43.google.com with SMTP id e52so1181348eek.30 for ; Thu, 05 Sep 2013 14:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0XBSyq/JQdOfKE1tUSxLEhObAMe41PhDk1PD1y0ExIQ=; b=MW20spU+ulzqmjsItyW1RCwZ/035K4Idj19TRCc2/LcSZKzmCcX2pW8nalhzn9PYKg sOIUPpq+JIvL/KZ1TmK+4D1sLFganpvj6ExMaikiN92MFj+SZShlkQUIKr3gyPZAPJvp RydPyenRGuHoIcAFl1gtl9L99EwMXeGGWx2Mw2q9LDJ5CTtlBIcspeKSEwyfisi2dBuj 8ZlLymIhv8xO8p+Ij9ySuGs3/DZ895qDrbmZDx5K3R5rHKJp2wFRTlPF6zDkKS9moonx ew0I0IGofmH+UPMZHj4qIdkKTOOmy/7r64ecRaIeECxsVyudJZY0BpgErie0XtUpk7me NXbw== X-Received: by 10.14.87.135 with SMTP id y7mr515245eee.69.1378414969783; Thu, 05 Sep 2013 14:02:49 -0700 (PDT) Received: from [192.168.1.102] (ajg161.neoplus.adsl.tpnet.pl. [83.25.240.161]) by mx.google.com with ESMTPSA id b45sm51836694eef.4.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Sep 2013 14:02:49 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Content-Type: text/plain; charset=iso-8859-2 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: New iSCSI stack. From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= In-Reply-To: Date: Thu, 5 Sep 2013 23:02:47 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <240FF3FA-E757-417A-B08A-4413533A34D1@freebsd.org> References: <34CEBF66-08BF-4265-8558-4A4A62109C77@FreeBSD.org> <5228D1A6.4020405@quip.cz> To: Outback Dingo X-Mailer: Apple Mail (2.1508) Cc: freebsd-scsi@freebsd.org, freebsd-arch@freebsd.org, freebsd-current@freebsd.org, Miroslav Lachman <000.fbsd@quip.cz>, Ivan Voras X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 21:09:00 -0000 Wiadomo=B6=E6 napisana przez Outback Dingo w = dniu 5 wrz 2013, o godz. 22:03: >=20 > On Thu, Sep 5, 2013 at 2:47 PM, Miroslav Lachman <000.fbsd@quip.cz> = wrote: > Edward Tomasz Napiera=B3a wrote: > Wiadomo=B6=E6 napisana przez Ivan Voras w dniu 5 = wrz 2013, o godz. 13:18: > On 05/09/2013 12:27, Edward Tomasz Napiera=B3a wrote: > Hello. At http://people.freebsd.org/~trasz/cfiscsi-20130904.diff = you'll find > a patch which adds the new iSCSI initiator and target, against = 10-CURRENT. > To use the new initiator, start with "man iscsictl". For the target - = "man > ctld". >=20 > Just a naming question: "ctld" could mean anything, I'd parse it as a > "control deamon" or something like that. Could you name it something > which reminds the user of iscsi? Like iscsictld? >=20 > As the man page says, ctld is "CAM Target Layer / iSCSI target = daemon". > Sure, right now it's pretty iSCSI-specific, but it doesn't need to be = - it can > be extended to just manage CTL configuration (e.g. for Fibre Channel), > or to support other CTL-backed storage protocols, such as FCoE. >=20 > It's just a helper daemon for ctl(4) - thus, ctld(8). And in case = someone > does "man -k iscsi", there is the "iSCSI target" in the manual page = title. >=20 > I understand your explanation, but still thinking rc.conf variables = are really confusing and unintuitive: >=20 > iscsid_enable > iscsictl_enable > ctld_enable >=20 > I cannot tell what they control just by their names and the same apply = for services names. >=20 > "If I want to restart iscsi target, should I use 'service iscsid = restart' or 'service iscsictl restart'? ... oh wait, it should be = 'service ctld restart'" >=20 > I think it should be more user friendly. Something as Apache 2.2.x has = httpd and httpd.conf, but users are using 'service apache22 restart' and = 'apache22_enable=3D"YES"', because there can be more "http" daemons. >=20 > My $0.02 >=20 >=20 > Just an FYI 10_CURRENT svn info > Path: . > Working Copy Root Path: /usr/src > URL: http://svn.freebsd.org/base/head > Relative URL: ^/head > Repository Root: http://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 255253 > Node Kind: directory > Schedule: normal > Last Changed Author: sjg > Last Changed Rev: 255253 > Last Changed Date: 2013-09-05 11:57:26 -0400 (Thu, 05 Sep 2013) >=20 >=20 > cc -O2 -pipe -I/usr/src/usr.sbin/ctld = -I/usr/src/usr.sbin/ctld/../../sys = -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl = -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 = -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall = -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes = -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual = -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align = -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls = -Wold-style-definition -Wno-pointer-sign -Wno-empty-body = -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/ctld.c > cc -O2 -pipe -I/usr/src/usr.sbin/ctld = -I/usr/src/usr.sbin/ctld/../../sys = -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl = -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 = -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall = -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes = -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual = -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align = -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls = -Wold-style-definition -Wno-pointer-sign -Wno-empty-body = -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/discovery.c > cc -O2 -pipe -I/usr/src/usr.sbin/ctld = -I/usr/src/usr.sbin/ctld/../../sys = -I/usr/src/usr.sbin/ctld/../../sys/cam/ctl = -I/usr/src/usr.sbin/ctld/../../sys/dev/iscsi -std=3Dgnu99 = -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall = -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes = -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual = -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align = -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls = -Wold-style-definition -Wno-pointer-sign -Wno-empty-body = -Wno-string-plus-int -c /usr/src/usr.sbin/ctld/kernel.c > /usr/src/usr.sbin/ctld/kernel.c:762:35: error: incompatible integer to = pointer conversion passing 'unsigned long long' to parameter of type = 'const cap_rights_t *' (aka 'const struct cap_rights *') = [-Werror,-Wint-conversion] > error =3D cap_rights_limit(ctl_fd, CAP_IOCTL); > ^~~~~~~~~ > /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:197:20: note: = expanded from macro 'CAP_IOCTL' > #define CAP_IOCTL CAPRIGHT(1, 0x0000000000000080ULL) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:53:28: note: = expanded from macro 'CAPRIGHT' > #define CAPRIGHT(idx, bit) ((1ULL << (57 + (idx))) | (bit)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/src/usr.sbin/ctld/../../sys/sys/capability.h:327:50: note: = passing argument to parameter 'rights' here > int cap_rights_limit(int fd, const cap_rights_t *rights); Yeah, broken by Capsicum changes committed earlier today. I'll update = the patch soon. >=20