From owner-svn-src-all@freebsd.org Wed Oct 16 07:49:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A834215E325; Wed, 16 Oct 2019 07:49:23 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46tPZW2Pppz4Nw9; Wed, 16 Oct 2019 07:49:22 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x9G7nEhZ030515 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 16 Oct 2019 10:49:17 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x9G7nEhZ030515 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x9G7nEdh030514; Wed, 16 Oct 2019 10:49:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 16 Oct 2019 10:49:14 +0300 From: Konstantin Belousov To: Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r353625 - in head/cddl/contrib/opensolaris/lib/libzpool/common: . sys Message-ID: <20191016074914.GE73312@kib.kiev.ua> References: <201910160741.x9G7fYJo022675@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201910160741.x9G7fYJo022675@repo.freebsd.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 46tPZW2Pppz4Nw9 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.990,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Oct 2019 07:49:23 -0000 On Wed, Oct 16, 2019 at 07:41:34AM +0000, Andriy Gapon wrote: > Author: avg > Date: Wed Oct 16 07:41:33 2019 > New Revision: 353625 > URL: https://svnweb.freebsd.org/changeset/base/353625 > > Log: > zfs: add a lame emulation of cv_wait_sig(9) in userland to fix r353618 > > Not sure if we need anything better. > Maybe we should try to port illumos libfakekernel or provide something > similar natively. > > MFC after: 4 weeks > X-MFC with: r353618 > > Modified: > head/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c > head/cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h > > Modified: head/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c > ============================================================================== > --- head/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c Wed Oct 16 07:20:59 2019 (r353624) > +++ head/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c Wed Oct 16 07:41:33 2019 (r353625) > @@ -321,6 +321,18 @@ cv_wait(kcondvar_t *cv, kmutex_t *mp) > mp->m_owner = curthread; > } > > +/* > + * NB: this emulates FreeBSD cv_wait_sig(9), not the illumos one. > + * Meanings of the return code is different. > + * NB: this does not actually catch any siganls. s/siganls/signals/