From owner-cvs-all@FreeBSD.ORG  Thu Dec 29 19:32:42 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A970916A432;
	Thu, 29 Dec 2005 19:32:42 +0000 (GMT) (envelope-from nate@root.org)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5509143D5E;
	Thu, 29 Dec 2005 19:32:38 +0000 (GMT) (envelope-from nate@root.org)
Received: from [10.0.5.50] (ppp-71-139-31-194.dsl.snfc21.pacbell.net
	[71.139.31.194])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id jBTJWs9e027093
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Thu, 29 Dec 2005 11:32:55 -0800
Message-ID: <43B4385D.9030206@root.org>
Date: Thu, 29 Dec 2005 11:26:21 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Alexander Leidinger <netchild@FreeBSD.org>
References: <20051229183552.205C316A432@hub.freebsd.org>
In-Reply-To: <20051229183552.205C316A432@hub.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb ums.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Dec 2005 19:32:42 -0000

Alexander Leidinger wrote:
> netchild    2005-12-29 18:35:28 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/usb          ums.c 
>   Log:
>   Sync the type (and size, compare mousestatus_t in /usr/include/sys/mouse.h)
>   of a variable according to the usage (after increasing the number of max
>   buttons this may matter).
>   
>   Noticed by:     flz
>   
>   Revision  Changes    Path
>   1.80      +1 -1      src/sys/dev/usb/ums.c
> 
> 
> Index: src/sys/dev/usb/ums.c
> diff -u src/sys/dev/usb/ums.c:1.79 src/sys/dev/usb/ums.c:1.80
> --- src/sys/dev/usb/ums.c:1.79	Thu Dec 29 17:44:40 2005
> +++ src/sys/dev/usb/ums.c	Thu Dec 29 18:35:28 2005
> @@ -425,7 +425,7 @@
>  	struct ums_softc *sc = addr;
>  	u_char *ibuf;
>  	int dx, dy, dz, dt;
> -	u_char buttons = 0;
> +	int buttons = 0;
>  	int i;
>  
>  #define UMS_BUT(i) ((i) < 3 ? (((i) + 2) % 3) : (i))

I think the UMS_BUT macro operates on only 2 bits.  Are you sure that's 
still right?

-- 
Nate