Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Nov 2006 16:30:29 +0100
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Kip Macy <kmacy@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/coda coda_vnops.c coda_vnops.h src/sys/fs/nullfs null_vnops.c src/sys/kern vfs_default.c vfs_subr.c vfs_vnops.c vnode_if.src src/sys/sys vnode.h src/sys/ufs/ffs ffs_vnops.c
Message-ID:  <20061113153029.GC25940@garage.freebsd.pl>
In-Reply-To: <200611130551.kAD5pNIP001371@repoman.freebsd.org>
References:  <200611130551.kAD5pNIP001371@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--gr/z0/N6AeWAPJVB
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 13, 2006 at 05:51:22AM +0000, Kip Macy wrote:
> kmacy       2006-11-13 05:51:22 UTC
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     sys/coda             coda_vnops.c coda_vnops.h=20
>     sys/fs/nullfs        null_vnops.c=20
>     sys/kern             vfs_default.c vfs_subr.c vfs_vnops.c=20
>                          vnode_if.src=20
>     sys/sys              vnode.h=20
>     sys/ufs/ffs          ffs_vnops.c=20
>   Log:
>   change vop_lock handling to allowing tracking of callers' file and line=
 for
>   acquisition of lockmgr locks
[...]
> --- src/sys/coda/coda_vnops.c	2006/02/01 00:25:24	1.68
> +++ src/sys/coda/coda_vnops.c	2006/11/13 05:51:21	1.69
[...]
>      .vop_reclaim =3D coda_reclaim,	/* reclaim */
> -    .vop_lock =3D coda_lock,		/* lock */
> +    ._vop_lock =3D coda_lock,		/* lock */
>      .vop_unlock =3D coda_unlock,		/* unlock */
[...]
> --- src/sys/fs/nullfs/null_vnops.c	2006/03/12 04:58:18	1.91
> +++ src/sys/fs/nullfs/null_vnops.c	2006/11/13 05:51:21	1.92
[...]
>  	.vop_islocked =3D		null_islocked,
> -	.vop_lock =3D		null_lock,
> +	._vop_lock =3D		null_lock,
>  	.vop_lookup =3D		null_lookup,
[...]
> --- src/sys/kern/vfs_default.c	2006/09/20 00:27:02	1.134
> +++ src/sys/kern/vfs_default.c	2006/11/13 05:51:22	1.135
[...]
>  	.vop_lease =3D		VOP_NULL,
> -	.vop_lock =3D		vop_stdlock,
> +	._vop_lock =3D		vop_stdlock,
>  	.vop_lookup =3D		vop_nolookup,
[...]
> --- src/sys/kern/vfs_subr.c	2006/11/07 19:45:05	1.691
> +++ src/sys/kern/vfs_subr.c	2006/11/13 05:51:22	1.692
[...]
>  	.vop_reclaim =3D	sync_reclaim,	/* reclaim */
> -	.vop_lock =3D	vop_stdlock,	/* lock */
> +	._vop_lock =3D	vop_stdlock,	/* lock */
>  	.vop_unlock =3D	vop_stdunlock,	/* unlock */
> --- src/sys/ufs/ffs/ffs_vnops.c	2006/11/06 13:42:09	1.162
> +++ src/sys/ufs/ffs/ffs_vnops.c	2006/11/13 05:51:22	1.163
[...]
>  	.vop_getpages =3D		ffs_getpages,
> -	.vop_lock =3D		ffs_lock,
> +	._vop_lock =3D		ffs_lock,
>  	.vop_read =3D		ffs_read,
[...]
>  	.vop_getpages =3D		ffs_getpages,
> -	.vop_lock =3D		ffs_lock,
> +	._vop_lock =3D		ffs_lock,
>  	.vop_read =3D		ffs_read,
[...]
>  	.vop_fsync =3D		ffs_fsync,
> -	.vop_lock =3D		ffs_lock,
> +	._vop_lock =3D		ffs_lock,
>  	.vop_reallocblks =3D	ffs_reallocblks,

Kip... This is so ugly... All the rest of vops don'y have this _ prefix.
There is really no other way to implement it?

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--gr/z0/N6AeWAPJVB
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (FreeBSD)

iD8DBQFFWI+VForvXbEpPzQRAhYpAJsEZh9gB6uhF6Dr9iviOCKbStj5zgCfVerh
DBunR/N1qwadV8yyuSy6sSI=
=AAuR
-----END PGP SIGNATURE-----

--gr/z0/N6AeWAPJVB--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061113153029.GC25940>