From owner-cvs-src@FreeBSD.ORG Mon Oct 30 18:45:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8033816A407; Mon, 30 Oct 2006 18:45:23 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail28.syd.optusnet.com.au (mail28.syd.optusnet.com.au [211.29.133.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80DBF43D4C; Mon, 30 Oct 2006 18:45:22 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c58-107-94-118.belrs4.nsw.optusnet.com.au [58.107.94.118]) by mail28.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k9UIj8ZD026209 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 31 Oct 2006 05:45:09 +1100 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.8/8.13.8) with ESMTP id k9UIj8gg003487; Tue, 31 Oct 2006 05:45:08 +1100 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.8/8.13.8/Submit) id k9UIj85F003486; Tue, 31 Oct 2006 05:45:08 +1100 (EST) (envelope-from peter) Date: Tue, 31 Oct 2006 05:45:08 +1100 From: Peter Jeremy To: LI Xin Message-ID: <20061030184508.GE871@turion.vk2pj.dyndns.org> References: <200610300332.k9U3W9xF099044@repoman.freebsd.org> <20061030090054.GC871@turion.vk2pj.dyndns.org> <4545C86A.1030008@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9l24NVCWtSuIVIod" Content-Disposition: inline In-Reply-To: <4545C86A.1030008@delphij.net> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.13 (2006-08-11) Cc: freebsd-hackers@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI , cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG Subject: Re: [patch] rm can have undesired side-effects X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2006 18:45:23 -0000 --9l24NVCWtSuIVIod Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, 2006-Oct-30 17:39:54 +0800, LI Xin wrote: >Well thought, I think that you are correct that specifying -P should do >nothing but generate a warning. > >In addition to this I have changed the behavior a bit (patch attached) >that, if -f is specified along with -P, the overwritten is happen and >the link would be removed. Please let me know if you are happy with >this change. I prefer this patch to what was committed. It still has foot-shooting potential but I don't believe that there have been massive screams about the current -P behaviour so presumably not too many people have accidently destroyed the content of a file they still wanted when deleting an unwanted link to the file. IMHO, rm.1 should explicitly state that "rm -fP" on a multi-linked file will destry the file contents as seen via the remaining link(s). This probably belongs in the "NOTE" section. --=20 Peter Jeremy --9l24NVCWtSuIVIod Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFRkg0/opHv/APuIcRAukbAJ9K4uYUcvlcYYxJ3yK65aaOmGqN0gCdFh/w W7x3Wgznu6+ojtacJGsiw5c= =S+e2 -----END PGP SIGNATURE----- --9l24NVCWtSuIVIod--