Date: Mon, 27 Sep 2010 17:40:59 +0200 From: Attilio Rao <attilio@freebsd.org> To: sbruno@freebsd.org Cc: "current@freebsd.org" <current@freebsd.org> Subject: Re: MAXCPU preparations Message-ID: <AANLkTik6zrh51G-0d7Nh=CgztGxsHxD_KOhjaeoBB0L2@mail.gmail.com> In-Reply-To: <1285601161.7245.7.camel@home-yahoo> References: <1285601161.7245.7.camel@home-yahoo>
next in thread | previous in thread | raw e-mail | index | archive | help
2010/9/27 Sean Bruno <seanbru@yahoo-inc.com>:
> Does this look like an appropriate modification to libmemstat?
>
> Sean
>
>
> =3D=3D=3D=3D //depot/yahoo/ybsd_7/src/lib/libmemstat/memstat.h#4
> - /home/seanbru/ybsd_7/src/lib/libmemstat/memstat.h =3D=3D=3D=3D
> @@ -28,12 +28,13 @@
>
> =C2=A0#ifndef _MEMSTAT_H_
> =C2=A0#define =C2=A0 =C2=A0 =C2=A0 =C2=A0_MEMSTAT_H_
> +#include <sys/param.h>
>
> =C2=A0/*
> =C2=A0* Number of CPU slots in library-internal data structures. =C2=A0Th=
is
> should be
> =C2=A0* at least the value of MAXCPU from param.h.
> =C2=A0*/
> -#define =C2=A0 =C2=A0 =C2=A0 =C2=A0MEMSTAT_MAXCPU =C2=A064
> +#define =C2=A0 =C2=A0 =C2=A0 =C2=A0MEMSTAT_MAXCPU =C2=A0MAXCPU /* define=
d in
> sys/${ARCH}/include/param.h */
>
> =C2=A0/*
> =C2=A0* Amount of caller data to maintain for each caller data slot.
> Applications
I would not include sys/param and would axe out the comment.
Just make sure anything compiles with these modifies eventually.
Thanks,
Attilio
--=20
Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTik6zrh51G-0d7Nh=CgztGxsHxD_KOhjaeoBB0L2>