Date: Wed, 31 Oct 2012 16:48:42 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: R?mi Pauchet <remi.pauchet@netasq.com>, jfv@FreeBSD.org, melifaro@FreeBSD.org Cc: freebsd-net@FreeBSD.org Subject: Re: panic ixgbevf / SMP under high network load Message-ID: <20121031124842.GS70741@FreeBSD.org> In-Reply-To: <B722D1A8-AA5F-4B80-8F84-B3935D72A498@netasq.com> References: <B722D1A8-AA5F-4B80-8F84-B3935D72A498@netasq.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--WlEyl6ow+jlIgNUh Content-Type: text/plain; charset=koi8-r Content-Disposition: inline [back to list and adding Jack to Cc] On Thu, Oct 25, 2012 at 10:06:40AM +0200, R?mi Pauchet wrote: R> I'm testing network performance of FreeBSD using vmware esxi 5.1 with SR-IOV R> R> I'm using FreeBSD 8.3 kernel GENERIC, 4 cpus, ixgbevf driver with an Intel 82599EB dual 10 Gbps network interface R> R> After a few seconds of udp ipv4 load (5Gbps x2, frame size 700), I have the following panic : Remi reported that attached patch fixes the panic. Looks like ixv_rxeof() isn't thread safe since doesn't expect its state being changed while lock is temporarily dropped. This is deja vu of an old problem in em(4): http://freshbsd.org/commit/freebsd/r151314 Similar fix can be made for ixgbe(4). However, recently we had discussion on removing this unlock entirely from drivers. Unlock/lock removal would not only fix such kind of problems, but also would speed up processing. Discussion starts here: http://lists.freebsd.org/pipermail/freebsd-net/2012-October/033520.html -- Totus tuus, Glebius. --WlEyl6ow+jlIgNUh Content-Type: text/x-diff; charset=koi8-r Content-Disposition: attachment; filename="ixv.c.diff" Index: ixv.c =================================================================== --- ixv.c (revision 242127) +++ ixv.c (working copy) @@ -3250,9 +3250,7 @@ if (tcp_lro_rx(&rxr->lro, m, 0) == 0) return; } - IXV_RX_UNLOCK(rxr); (*ifp->if_input)(ifp, m); - IXV_RX_LOCK(rxr); } static __inline void --WlEyl6ow+jlIgNUh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121031124842.GS70741>