Date: Sat, 08 Feb 2014 17:02:47 -0500 From: John Baldwin <jhb@freebsd.org> To: Roger Pau Monne <roger.pau@citrix.com> Cc: julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, xen-devel@lists.xenproject.org, gibbs@freebsd.org Subject: Re: [PATCH RFC 12/13] mca: disable cmc enable on Xen PV Message-ID: <2452208.OksOsMWhSU@ralph.baldwin.cx> In-Reply-To: <1387884062-41154-13-git-send-email-roger.pau@citrix.com> References: <1387884062-41154-1-git-send-email-roger.pau@citrix.com> <1387884062-41154-13-git-send-email-roger.pau@citrix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, December 24, 2013 12:21:01 PM Roger Pau Monne wrote: > Xen PV guests doesn't have a lapic, so disable the lapic call in mca > initialization. I think this is fine, but I wonder if it wouldn't be cleaner to have lapic_enable_cmc() do the check instead. Where else do you check lapic_disabled? > --- > sys/x86/x86/mca.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c > index f1369cd..e9d2c1d 100644 > --- a/sys/x86/x86/mca.c > +++ b/sys/x86/x86/mca.c > @@ -897,7 +897,7 @@ _mca_init(int boot) > } > > #ifdef DEV_APIC > - if (PCPU_GET(cmci_mask) != 0 && boot) > + if (PCPU_GET(cmci_mask) != 0 && boot && !lapic_disabled) > lapic_enable_cmc(); > #endif > } -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2452208.OksOsMWhSU>