From owner-svn-src-all@FreeBSD.ORG Thu Oct 2 18:35:31 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C89595B9; Thu, 2 Oct 2014 18:35:31 +0000 (UTC) Received: from mail.made4.biz (mail.made4.biz [IPv6:2001:41d0:2:c018::1:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8B5E9D98; Thu, 2 Oct 2014 18:35:31 +0000 (UTC) Received: from 2a02-8428-011b-e000-0290-f5ff-fe9d-b78c.rev.sfr.net ([2a02:8428:11b:e000:290:f5ff:fe9d:b78c] helo=magellan.dumbbell.fr) by mail.made4.biz with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.84 (FreeBSD)) (envelope-from ) id 1XZlDt-000NHa-Mf; Thu, 02 Oct 2014 20:35:29 +0200 Message-ID: <542D9AED.6060805@FreeBSD.org> Date: Thu, 02 Oct 2014 20:35:25 +0200 From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: svn-src-all@freebsd.org, Hiroki Sato Subject: Re: svn commit: r272386 - in head: sbin/ifconfig share/man/man4 sys/net References: <201410012137.s91LbXL4025967@svn.freebsd.org> In-Reply-To: <201410012137.s91LbXL4025967@svn.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="INET5QpKHcGqpMp81aEvCN60libwLEbqG" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Oct 2014 18:35:32 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --INET5QpKHcGqpMp81aEvCN60libwLEbqG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > Author: hrs > Date: Wed Oct 1 21:37:32 2014 > New Revision: 272386 > URL: https://svnweb.freebsd.org/changeset/base/272386 >=20 > Log: > Virtualize lagg(4) cloner. This change fixes a panic when tearing do= wn > if_lagg(4) interfaces which were cloned in a vnet jail. Hi! I believe this change needs at least an entry in UPDATING, because an ifconfig(8) binary built before this commit fails to change laggproto on a kernel including this commit. The error is the following: # ifconfig lagg0 laggproto failover ifconfig: SIOCSLAGG: Invalid argument By quickly looking at the code, I would say that the culprit is the change in size of the "struct lag_reqall". The new "ra_opts" field in "struct lagg_reqall" isn't initialized in the incompatible ifconfig(8) binary. This could be considered invalid options, leading to "error =3D EINVAL" in if_lagg.c:1301. Another non-critical regression is that this ifconfig(8) binary doesn't display the laggproto and laggport lines. I mean those lines: # ifconfig lagg0 lagg0: flags=3D8843 (...) (...) laggproto failover lagghash l2,l3,l4 laggport: wlan0 flags=3D0<> laggport: re0 flags=3D5 Beside an UPDATING entry, how about a previously released world with this new kernel? Isn't this configuration supposed to work? --=20 Jean-S=C3=A9bastien P=C3=A9dron --INET5QpKHcGqpMp81aEvCN60libwLEbqG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJULZrxXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTMYVQP/0PPlnZusCHDst/k/zPqo31/ IdwUeUZWZWKXWQPWu2Ae/XSVysB683M0oasDFq/exalh7un70gBI+U0Pxr3xfzaR 323ZpX1X48guGKK1U6Do2wAPGCmhL1TXqyAnhlIdNVACEHuy3yTj+UIyrjwBDFVS tJ4PG3BK7PVLdOaWSFbqFDETmkqqO9xV2Kz+wQVT+gRBUUYeriA/0tGushfS9K2k ShDDIR7Gf7ik4b5ubKluHpYU6EkSOXeO+losjqR/pDNVbyp3QI3Y08we5BKaev2D MLfnjd5Gvuou3FKF5s3FXXdYRmA0+9vihRgTBfm9LEchUtk/UcSFYCWSg76D+6MC oTbuYK92Q4krGyl3PGtvHnIamndBP5vmiAMtPKS9tDZaXFIFJDnrUFg8nc14rOA/ 1bPQsJMSMqRZrvZ4rcLu8VWFo5kE/0QHaZpcRHApfgdfOzo+n0z4BwJJAr45Ueia tZHmmZq6bitdjLtuwVVTQkrOzi65AvsgagI3mqzTU9rAgzQfnWkrQmPV6CMJLaVx KGLUPLbtUGgTvXJVyoHUQ/skXDJ8YcCd3AmNcruQjiHD6CMw/N9h6/8zKzorq3QH OphOKF22GQPIigt1YnZ/eiJhSGCfT6Eyz+fYt9ZH9Wt2e//cnTIECPhV7UUrqxsm 7u5aO/kHSKHdas+nYSzj =195E -----END PGP SIGNATURE----- --INET5QpKHcGqpMp81aEvCN60libwLEbqG--