From owner-svn-src-head@freebsd.org Mon Mar 30 02:20:50 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4C6ED26D369; Mon, 30 Mar 2020 02:20:50 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48rGQl6f16z3K0j; Mon, 30 Mar 2020 02:20:47 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 02U2Fsmw053933; Sun, 29 Mar 2020 19:15:54 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 02U2Fsad053932; Sun, 29 Mar 2020 19:15:54 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202003300215.02U2Fsad053932@gndrsh.dnsmgr.net> Subject: Re: svn commit: r359419 - head/usr.bin/ncal In-Reply-To: <20200330015536.GH87815@eureka.lemis.com> To: "Greg 'groggy' Lehey" Date: Sun, 29 Mar 2020 19:15:54 -0700 (PDT) CC: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Reply-To: rgrimes@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 48rGQl6f16z3K0j X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2020 02:20:50 -0000 -- Start of PGP signed section. > On Sunday, 29 March 2020 at 18:29:40 -0700, Rodney W. Grimes wrote: > >> On Sunday, 29 March 2020 at 4:03:09 -0700, Rodney W. Grimes wrote: > >>>> Author: grog > >>>> Date: Sun Mar 29 04:18:27 2020 > >>>> New Revision: 359419 > >>>> URL: https://svnweb.freebsd.org/changeset/base/359419 > >>>> > >>>> Log: > >>>> Remove spurious transition from Julian to Gregorian for country > >>>> "Latin". > >>>> > >>>> Arguably the entire -p option should be removed. It shows only a few > >>>> countries, and it doesn't have any relationship with the rest of the > >>>> program. > >>> > >>> This commit message and the diff below do not seem to match very well. > >>> Is this actually what you intended to commit? > >> > >> The material difference, yes. Do you have an issue with that? > > > > No, just that it seemed that an error may of happened, > > but having you confirm this infact was the inteded change > > I am quiet fine with it. > > Thanks. > > Do you have any thoughts on removing the -p option? It just prints a table right? Why does it need removed? The Latin one had a bogus year, and the table is sparse, but probably contains valid data for 90+% of the user base. Doesnt the data still have to be in the program to properly print calendars before the switch date? > >> It seems that some trailing blanks in unrelated text were removed as > >> well. diff doesn't show these by default, so they crept through. I > >> know it's bad style to mix style commits with functional commits, but > >> ultimately they had to go too. > > > > Diff by default does show white space change, > > one has to invoke it with -b or -w or one of the --ignore space > > change options to cause it to not show them. > > Right. Egg on my face, and you can be sure I'll run diff with the > correct options next time. > > Greg > -- > Sent from my desktop computer. > Finger grog@FreeBSD.org for PGP public key. > See complete headers for address and phone numbers. > This message is digitally signed. If your Microsoft mail program > reports problems, please read http://lemis.com/broken-MUA -- End of PGP section, PGP failed! -- Rod Grimes rgrimes@freebsd.org