Date: Wed, 17 May 2017 20:27:12 -0600 From: Adam Weinberger <adamw@adamw.org> To: Rodrigo Osorio <rodrigo@osorio.me> Cc: Rodrigo Osorio <rodrigo@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r440978 - in head: devel devel/npm-amdefine devel/npm-clean-css devel/npm-clean-css/files devel/npm-commander devel/npm-commander/files devel/npm-graceful-readlink devel/npm-source-map ... Message-ID: <ACA00AA8-03A5-4AE5-BD72-53F076DD4E63@adamw.org> In-Reply-To: <afe6f1eb-502a-3a12-4896-38bdfdbd4f65@osorio.me> References: <201705152205.v4FM5kIw055373@repo.freebsd.org> <6F0B8538-C30A-42A4-A3C3-D0BA1FA8F6F4@adamw.org> <afe6f1eb-502a-3a12-4896-38bdfdbd4f65@osorio.me>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 16 May, 2017, at 2:57, Rodrigo Osorio <rodrigo@osorio.me> wrote: >=20 > On 05/16/17 00:27, Adam Weinberger wrote: >>> On 15 May, 2017, at 16:05, Rodrigo Osorio <rodrigo@FreeBSD.org> = wrote: >>>=20 >>> Author: rodrigo >>> Date: Mon May 15 22:05:46 2017 >>> New Revision: 440978 >>> URL: https://svnweb.freebsd.org/changeset/ports/440978 >>>=20 >>> Log: >>> Add npm-less-plugin-clean-css a www/lesc tool pluggin and its = dependencies >>>=20 >>> www/npm-less-plugin-clean-css: Compresses the css output from less = using clean-css >>> ` devel/npm-clean-css: Fast and efficient CSS optimizer for node.js = and the Web >>> ` devel/npm-source-map: Parse and consume source maps >>> | ` devel/npm-amdefine: Implementation of AMD's define() in Node >>> ` devel/npm-commander: node.js command-line interfaces made easy >>> ` devel/npm-graceful-readlink: Graceful fs.readlink >> What do all these ports do that npm doesn't already do, especially = given that this will cause breakage for everybody with any of these = modules installed globally? >>=20 >> # Adam >>=20 >>=20 > Hi Adam, >=20 > That's npm dependencies that need to be packages properly, I'll feel = unsafe if the port > relies on npm to download external sources from github during the = packaging, without > checking the integrity. >=20 > Of course, this could be an issue for peoples who deploys npm packages = on their own, > but how can we handle this ? Maybe dep search path should be set = manually if you > install unpackaged npm tools ? >=20 > I run a quick test, but apparently node uses in tree dependencies = before global. The summary here is that having node packages in the ports tree causes = more problems than it solves. A clarification of packaging policy is = forthcoming, but the gist of it is that node packages aren't candidates = for ports unless they're dependencies of other ports. Plus, = npm-clean-css is causing build failures on at least one builder = (http://package19.nyi.freebsd.org/data/103i386-default-build-as-user/44106= 2/logs/npm-clean-css-4.1.1.log). These ports should be backed out please, Rodrigo. I'll explain more = shortly in response to David Naylor's email in this thread. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ACA00AA8-03A5-4AE5-BD72-53F076DD4E63>