From owner-cvs-all Fri Sep 14 14: 9:48 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 01F6737B407; Fri, 14 Sep 2001 14:09:41 -0700 (PDT) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id f8EL9CB98302; Fri, 14 Sep 2001 14:09:12 -0700 (PDT) (envelope-from obrien) Date: Fri, 14 Sep 2001 14:09:12 -0700 From: "David O'Brien" To: Brian Somers Cc: Josef Karthauser , Garance A Drosihn , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Proposed patch to log_accum.pl Message-ID: <20010914140912.B98219@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200109140929.f8E9Tpd26809@hak.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200109140929.f8E9Tpd26809@hak.lan.Awfulhak.org>; from brian@freebsd-services.com on Fri, Sep 14, 2001 at 10:29:51AM +0100 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Sep 14, 2001 at 10:29:51AM +0100, Brian Somers wrote: > > Revision Changes Path > > 1.108 +6 -5 src/sys/kern/kern_descrip.c > > 1.1 +123 X src/sys/kern/new_file.c (new) > > 1.234 X -669 src/sys/kern/dead_file.c (attic) > > > > or some other character to pad the column out, but to indicate that > > there's no value there? > > Hmm, I think the X looks odd. > > If we have (new) and (attic) then we don't need the Xs. If we have > the Xs (or even if we have nothing) we don't need the (new) or > (attic). > > Personally I prefer my original suggestion on the basis that it has > no duplicated information. Parsing is easy, but not as easy as > having a pad character. I assume you'll be fixing the `cvsmail' port then? :-) -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message