Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Feb 2018 03:20:24 +0800
From:      Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Yuri Victorovich <yuri@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r463151 - in head/audio/musicpc: . files
Message-ID:  <CAMHz58RR8Yp0EVXspunBC4ZQj%2BxHqWNeLH4vxWXcWTZp4=Udbg@mail.gmail.com>
In-Reply-To: <201802271852.w1RIqNUZ042258@repo.freebsd.org>
References:  <201802271852.w1RIqNUZ042258@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 28, 2018 at 2:52 AM, Yuri Victorovich <yuri@freebsd.org> wrote:

> Author: yuri
> Date: Tue Feb 27 18:52:22 2018
> New Revision: 463151
> URL: https://svnweb.freebsd.org/changeset/ports/463151
>
> Log:
>   audio/musicpc: Update to 0.29
>
>   Port changes:
>   * Changed to DISTVERSION
>   * Now uses meson instead of configure/make
>   * Added the MANPAGES option, manpage now is built by py-sphinx
>   * Removed targets that are now done by meson
>
>   PR:           226219
>   Submitted by: Zsolt Udvari <uzsolt@uzsolt.hu> (maintainer)
>   Approved by:  tcberner (mentor, implicit)
>   Differential Revision:        https://reviews.freebsd.org/D14531
>
> Added:
>   head/audio/musicpc/files/
>   head/audio/musicpc/files/patch-doc_meson.build   (contents, props
> changed)
>   head/audio/musicpc/files/patch-meson.build   (contents, props changed)
>   head/audio/musicpc/files/patch-meson__options.txt   (contents, props
> changed)
> Modified:
>   head/audio/musicpc/Makefile
>   head/audio/musicpc/distinfo
>
> Modified: head/audio/musicpc/Makefile
> ============================================================
> ==================
> --- head/audio/musicpc/Makefile Tue Feb 27 18:19:54 2018        (r463150)
> +++ head/audio/musicpc/Makefile Tue Feb 27 18:52:22 2018        (r463151)
> @@ -2,8 +2,7 @@
>  # $FreeBSD$
>
>  PORTNAME=      musicpc
> -PORTVERSION=   0.28
> -PORTREVISION=  1
> +DISTVERSION=   0.29
>  CATEGORIES=    audio ipv6
>  MASTER_SITES=  http://www.musicpd.org/download/mpc/0/
>  DISTNAME=      mpc-${PORTVERSION}
> @@ -16,32 +15,24 @@ LICENSE_FILE=       ${WRKSRC}/COPYING
>
>  LIB_DEPENDS=   libmpdclient.so:audio/libmpdclient
>
> -USES=          pkgconfig tar:xz
> -GNU_CONFIGURE= yes
> +USES=          meson pkgconfig python tar:xz
>

Hi yuri,

It seems this port does not require python to build and run.


> +MESON_ARGS+=   --mandir=${MANPREFIX}
>

Please use =


> -PLIST_FILES=   bin/mpc man/man1/mpc.1.gz
> +PLIST_FILES=   bin/mpc
>
> -PORTDOCS=      AUTHORS README NEWS
> -PORTEXAMPLES=  *
> +OPTIONS_DEFINE=        DOCS EXAMPLES MANPAGES ICONV
> +OPTIONS_DEFAULT=       MANPAGES ICONV
>
> -OPTIONS_DEFINE=        EXAMPLES DOCS ICONV
> -OPTIONS_DEFAULT=       ICONV
> +MANPAGES_USES= python
>

MANPAGES_USES=python:env is enough to expand PYTHON_PKGNAMEPREFIX and
PY_FLAVOR.


> +MANPAGES_BUILD_DEPENDS=        ${PYTHON_PKGNAMEPREFIX}sphinx>
> 0:textproc/py-sphinx@${PY_FLAVOR}
> +MANPAGES_MESON_TRUE=   use_sphinx
> +MANPAGES_PLIST_FILES=  man/man1/mpc.1.gz
>
>  ICONV_USES=    iconv
> -ICONV_LDFLAGS= -L${LOCALBASE}/lib ${ICONV_LIB}
> -ICONV_CONFIGURE_ENABLE=        iconv
> +ICONV_LDFLAGS= -L${ICONV_PREFIX}/lib ${ICONV_LIB}
> +ICONV_MESON_TRUE=      iconv
>
> -do-install:
> -       ${INSTALL_PROGRAM} ${WRKSRC}/src/mpc ${STAGEDIR}${PREFIX}/bin
> -       ${INSTALL_MAN} ${WRKSRC}/doc/mpc.1 ${STAGEDIR}${MAN1PREFIX}/man/
> man1
> -
> -do-install-DOCS-on:
> -       @${MKDIR} ${STAGEDIR}${DOCSDIR}
> -       ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
> -
> -do-install-EXAMPLES-on:
> -       @${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
> -       ${INSTALL_DATA} ${WRKSRC}/doc/mpc-completion.bash \
> -               ${STAGEDIR}${EXAMPLESDIR}
> +PORTDOCS=      AUTHORS README.rst NEWS
> +PORTEXAMPLES=  *
>
>  .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58RR8Yp0EVXspunBC4ZQj%2BxHqWNeLH4vxWXcWTZp4=Udbg>